Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Resolve #746] add before_launch and after_launch hooks #748

Merged
merged 3 commits into from
Feb 3, 2020

Conversation

cornerman
Copy link
Contributor

Add before_launch and after_launch hooks to do something whenever the stack is run.

PR Checklist

  • Wrote a good commit message & description [see guide below].
  • Commit message starts with [Resolve #issue-number].
  • Added/Updated unit tests.
  • Added/Updated integration tests (if applicable).
  • All unit tests (make test) are passing.
  • Used the same coding conventions as the rest of the project.
  • The new code passes flake8 (make lint) checks.
  • The PR relates to only one subject with a clear title.
    and description in grammatically correct, complete sentences.

Approver/Reviewer Checklist

  • Before merge squash related commits.

Other Information

Guide to writing a good commit

@ngfgrant ngfgrant changed the base branch from master to 2.1.6 June 28, 2019 13:54
@ngfgrant ngfgrant changed the base branch from 2.1.6 to master June 28, 2019 13:55
zaro0508
zaro0508 previously approved these changes Dec 27, 2019
Copy link
Contributor

@zaro0508 zaro0508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested with my project and this seems to be working as I would expect. @ngfgrant can we merge?

@ngfgrant
Copy link
Contributor

ngfgrant commented Feb 3, 2020

yep lets resolve docs/_source/docs/hooks.rst and ill merge it in

@cornerman
Copy link
Contributor Author

cornerman commented Feb 3, 2020

yep lets resolve docs/_source/docs/hooks.rst and ill merge it in

@ngfgrant resolved :)

@ngfgrant ngfgrant merged commit bb22891 into Sceptre:master Feb 3, 2020
@cornerman cornerman deleted the launch-hooks branch August 3, 2020 21:37
thawkson pushed a commit to thawkson/sceptre that referenced this pull request Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants