Explain why MCO+Ignition may not work for bond/vlan #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SchSeba
pushed a commit
that referenced
this pull request
Sep 2, 2020
The broken link is from 881dbb7 (Add initial enhancement templates, 2019-08-23, #2), with a sloppy copy from [1]. I'm fixing with a verbatim copy from the KEP template (and dropping template-only stuff from the user-workload-monitoring enhancement). This is a bit of a semantic change from what we had previously. The OpenShift vs. Kubernetes maturity levels are not clear to me. OpenShift does have docs on GA and later [2], and we do have docs on using Technology Preview features [3], but I have not turned up docs for what Technology preview means in terms of maturity/support. But even if there is a Kubernetes / OpenShift maturity distinction, OpenShift is going to expose Kubernetes features before they go stable. And we use v1beta1 and whatnot for OpenShift configs. So I don't think we can drop the Kubernetes maturity references altogether, although we can add OpenShift maturity references in addition (once we find out what to reference). I also went through existing enhancements and removed useless copies of the template boilerplate, to make it more clear that those particular enhancements did not have anything to say about graduation criteria. [1]: https://github.com/kubernetes/enhancements/blame/f1a799d5f4658ed29797c1fb9ceb7a4d0f538e93/keps/YYYYMMDD-kep-template.md#L216-L221 [2]: https://access.redhat.com/support/policy/updates/openshift/ [3]: https://docs.openshift.com/container-platform/4.2/nodes/clusters/nodes-cluster-enabling-features.html#nodes-cluster-features-about_nodes-cluster-enabling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.