Add rails 5.2 compatibility #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
a client of mine is using this gem and we need to update to rails 5.2 so I was trying to update all the dependencies and found that this gem is not compatible with rails 5.2 yet. Because we need to update to rails urgently I thought sending a PR would make things happening quicker.
I think I have updated everything in the correct way but locally I'm not able to run the test and double check it (not really familiar with your gems yet). So I was hoping to send this PR and let travis to double check everything and maybe get some feedbacks from you guys to fix what needs to be fixed
Thanks
Cheers