Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add theme.json schema annotations #1874

Merged
merged 27 commits into from
Oct 13, 2021
Merged

Add theme.json schema annotations #1874

merged 27 commits into from
Oct 13, 2021

Conversation

ajlende
Copy link
Contributor

@ajlende ajlende commented Oct 12, 2021 •
edited
Loading

This adds description and default value annotations to the theme.json schema.

It also adds required values for post types and template parts.

cc @mkaz

ajlende added 27 commits October 12, 2021 12:23
@ajlende
Add desceriptions for color settings
c85122b
@ajlende
Add default values for color settings booleans
31b872f
@ajlende
Add default values for typography settings booleans
14bb5b3
@ajlende
Add default values for spacing settings
836f235
@ajlende
Add default values for border settings
4569239
@ajlende
Add more detail to color preset descriptions
0749b99
@ajlende
Update color settings descriptions
2e998a9
@ajlende
Add typography settings descriptions
021d947
@ajlende
Update color settings descriptions
893af5e
@ajlende
Add border settings descriptions
2987466
@ajlende
Add layout settings descriptions
ba69174
@ajlende
Add spacing settings descriptions
79a2d8f
@ajlende
Add description for custom settings
37061c3
@ajlende
Fix settings.color.customDuotone version
80edb46
@ajlende
Add border styles descriptions
218b30a
@ajlende
Add color styles descriptions
74cdfa5
@ajlende
Add spacing styles descriptions
7f28df3
@ajlende
Add typography styles descriptions
87ee150
@ajlende
Add styles descriptions
415c2d2
@ajlende
Update styles descriptions
09672ac
@ajlende
Add required properties for templateParts and customTemplates
4747c85
@ajlende
Add custom templates descriptions and defaults
725b2aa
@ajlende
Add template parts descriptions and defaults
3e359da
@ajlende
Fix custom settings nested tooltips
2dd6780
@ajlende
Add descriptions for fontFamily and fontSize presets
6fcc441
@ajlende
Reorder fontFamily and fontSize preset values
1436d81
@ajlende
Refactor how settings.custom is defined
bc9405e
mkaz
mkaz approved these changes Oct 12, 2021
View reviewed changes
Copy link

@mkaz mkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The set of changes look good. It'll be quite useful, thanks! 👍

@ajlende ajlende marked this pull request as ready for review October 12, 2021 22:58
@madskristensen madskristensen merged commit ec5dedf into SchemaStore:master Oct 13, 2021
@madskristensen
Copy link
Contributor

Thanks

@fabiankaegy fabiankaegy mentioned this pull request Oct 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaz mkaz mkaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajlende @madskristensen @mkaz