Skip to content

Correct enum value in schema for .clang-format AllowShortIfStatementsOnASingleLine #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Correct enum value in schema for .clang-format AllowShortIfStatementsOnASingleLine #2384

merged 1 commit into from
Jul 29, 2022

Conversation

per1234
Copy link
Contributor

@per1234 per1234 commented Jul 29, 2022

The AllIfsAndElse enum value had a typo in the schema for the AllowShortIfStatementsOnASingleLine property of the .clang-format configuration file.

References:

https://github.com/llvm/llvm-project/blob/llvmorg-14.0.6/clang/lib/Format/Format.cpp

  * ``SIS_AllIfsAndElse`` (in configuration: ``AllIfsAndElse``)

https://github.com/llvm/llvm-project/blob/llvmorg-14.0.6/clang/docs/ClangFormatStyleOptions.rst?plain=1#L883

template <> struct ScalarEnumerationTraits<FormatStyle::ShortIfStyle> {
  static void enumeration(IO &IO, FormatStyle::ShortIfStyle &Value) {
    IO.enumCase(Value, "Never", FormatStyle::SIS_Never);
    IO.enumCase(Value, "WithoutElse", FormatStyle::SIS_WithoutElse);
    IO.enumCase(Value, "OnlyFirstIf", FormatStyle::SIS_OnlyFirstIf);
    IO.enumCase(Value, "AllIfsAndElse", FormatStyle::SIS_AllIfsAndElse);

@madskristensen
Copy link
Contributor

Thanks

Rolly992 added a commit to gradle/schemastore that referenced this pull request Aug 10, 2022
* upstream/master: (178 commits)
  liquibase flow file to describe objects and structure of json (SchemaStore#2400)
  Correct fly.toml env type (SchemaStore#2402)
  Adding deviceupdate import manifest schema version 5 (SchemaStore#2401)
  Mark *.schema.json as JSON schema draft 7 file (SchemaStore#2396)
  feature: Add "Common Catalog Schema" to the catalog (SchemaStore#2399)
  Fix wrong default values (SchemaStore#2398)
  feat: add better-scripts schema (SchemaStore#2397)
  feature: schema: update 🐊Putout schema (SchemaStore#2395)
  Update cargo-make.json (SchemaStore#2394)
  rename Datadog's service catalog definition file to service definition file (SchemaStore#2393)
  Add motif.json to catalog (SchemaStore#2392)
  Add Component Detection manifest schema (SchemaStore#2391)
  Add UTAM page object schema (SchemaStore#2390)
  github-workflow-template-properties: remove extension from `iconName` (SchemaStore#2389)
  fix(pre-commit): use `description` keyword instead of `$comment` (SchemaStore#2388)
  feat: add .talismanrc schema (SchemaStore#2387)
  fix(pre-commit-hooks): add missing properties (SchemaStore#2386)
  fix(semantic-release): Allow additionalProperties at the root (SchemaStore#2385)
  Correct enum value in schema for .clang-format `AllowShortIfStatementsOnASingleLine` (SchemaStore#2384)
  feat(bxci): add new major version (SchemaStore#2383)
  ...

# Conflicts:
#	src/api/json/catalog.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants