This repository has been archived by the owner on Jul 9, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 599
Add getValidThreadColors #512
Merged
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
8dd92bc
Merge pull request #5 from Schmavery/master
AstroCB ad82416
Add getValidThreadColors
AstroCB 0ee6e7f
Terminology fix
AstroCB 5297ed8
Force lowercase in API
AstroCB 0914474
Add thread color validation
AstroCB baf596e
Fix indentation
AstroCB b309626
Update thread color error checking
AstroCB aa9fa48
Fix spacing
AstroCB 1ee58a0
Rename vars
AstroCB 7752370
Switch to using a dictionary
AstroCB 05a64fc
Wording fix
AstroCB 7968a58
Rename to threadColors and move dep notice to CHANGELOG
AstroCB File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
"use strict"; | ||
|
||
module.exports = function(defaultFuncs, api, ctx) { | ||
// Currently the only colors that can be passed to api.changeThreadColor(); may change if Facebook adds more | ||
return { | ||
"MessengerBlue": null, | ||
"Viking": "#44bec7", | ||
"GoldenPoppy": "#ffc300", | ||
"RadicalRed": "#fa3c4c", | ||
"Shocking": "#d696bb", | ||
"PictonBlue": "#6699cc", | ||
"FreeSpeechGreen": "#13cf13", | ||
"Pumpkin": "#ff7e29", | ||
"LightCoral": "#e68585", | ||
"MediumSlateBlue": "#7646ff", | ||
"DeepSkyBlue": "#20cef5", | ||
"Fern": "#67b868", | ||
"Cameo": "#d4a88c", | ||
"BrilliantRose": "#ff5ca1", | ||
"BilobaFlower": "#a695c7" | ||
}; | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can move the note about "Due to Facebook backend changes, the thread color can no longer be set to an arbitrary hex value." to the CHANGELOG.md file and put a link there to this PR? (See the other entries for an example)