Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-build compilation fallback #678

Closed

Conversation

Schniz
Copy link
Owner

@Schniz Schniz commented Feb 23, 2022

Add the ability to add --force-arch to fnm env so if a prebuilt version is not found, fnm will use node-build to compile the Node.js version locally.

@Schniz Schniz self-assigned this Feb 23, 2022
path.pop();
path
};
let temp_installations_dir = tempfile::tempdir().unwrap();
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node-build does not support spaces in directories too. We need to find a solution for that 🥲
related:

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, the solution is to have a dirs module (which we already have) and probably store stuff in .local/fnm or something unless XDG_ env vars are provided, but I want to make the migration fast 🥲

@trm217
Copy link

trm217 commented Apr 21, 2022

@Schniz Could you need help working on this? I am currently having a bit of an issue with other team members using nvm and arm64 NodeV14, I would certainly look forward not having to switch back to nvm 😂

@Schniz
Copy link
Owner Author

Schniz commented Apr 21, 2022

I think it’s fairly finished. I’ll take another look and will release it on the next version. The only problem is node-build not supporting spaces in the installation path

@Schniz
Copy link
Owner Author

Schniz commented May 12, 2022

New MacOS version removes python@2 so build scripts fail. I think that the best solution is to have a precompiled repo: that would be both fast and easy to install.

@Schniz Schniz closed this Jun 30, 2023
@Schniz Schniz deleted the support-force-compilation-on-missing-m1-distributions branch June 30, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants