Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#208) Toast ์ƒ์„ฑ ํ•จ์ˆ˜ ๋งŒ๋“ค๊ธฐ #209

Merged
merged 2 commits into from
Jun 3, 2024
Merged

๐Ÿ”€ :: (#208) Toast ์ƒ์„ฑ ํ•จ์ˆ˜ ๋งŒ๋“ค๊ธฐ #209

merged 2 commits into from
Jun 3, 2024

Conversation

diejdkll
Copy link
Collaborator

@diejdkll diejdkll commented Jun 3, 2024

๐Ÿ’ก ๊ฐœ์š”

  • Toast ์ƒ์„ฑํ• ๋•Œ ์ค‘๋ณต๋œ ์ฝ”๋“œ๋ฅผ ํ•จ์ˆ˜๋กœ ๋”ฐ๋กœ ๋งŒ๋“ค๊ธฐ

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • Toast ์ƒ์„ฑ ํ•จ์ˆ˜ ์ถ”๊ฐ€
  • ๊ธฐ์กด Toast ๋ถ€๋ถ„์„ ์ƒˆ๋กœ ๋งŒ๋“  makeToast๋กœ ๋ณ€๊ฒฝ

๐Ÿ”€ ๋ณ€๊ฒฝ์‚ฌํ•ญ

  • ui ๋ชจ๋“ˆ์— makeToast ํ•จ์ˆ˜ ์ถ”๊ฐ€
  • feature ๋ชจ๋“ˆ์— toast -> makeToast๋กœ ๋ณ€๊ฒฝ

๐Ÿ™‹โ€โ™‚๏ธ ์งˆ๋ฌธ์‚ฌํ•ญ

์งˆ๋ฌธ ๋ฐ›์Šต๋‹ˆ๋‹ค

@diejdkll diejdkll added 3๏ธโƒฃ Priority: Low ์šฐ์„ ์ˆœ์œ„ - ํ•˜ โ™ป๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง labels Jun 3, 2024
@diejdkll diejdkll self-assigned this Jun 3, 2024
@diejdkll diejdkll linked an issue Jun 3, 2024 that may be closed by this pull request
Toast ์ƒ์„ฑ ํ•จ์ˆ˜ ๋งŒ๋“ค๊ธฐ #208
Closed
wjdcksdn
wjdcksdn approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@wjdcksdn wjdcksdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์˜ค ์ด๊ฑฐ ๋‹ค๋ฅธ๋ฐ์—๋„ ํ† ์ŠคํŠธ ์žˆ๋Š”์ง€ ๋ชจ๋ฅด๊ณ  ๊ธ‰ํ•˜๊ฒŒ ํ† ์ŠคํŠธ ์ถ”๊ฐ€ํ•˜๋Š๋ผ ๋‹ค์Œ์— ํ•จ์ˆ˜ํ™” ํ•ด์•ผ๊ฒ ๋‹ค ์ƒ๊ฐํ•˜๊ณ  ๊นŒ๋จน๊ณ  ์žˆ์—ˆ๋Š”๋ฐ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค

Chaejongin12
Chaejongin12 approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@Chaejongin12 Chaejongin12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ข‹์€ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค. ๐Ÿ‘
์ถ”ํ›„ ์•„ํ‚คํ…์ฒ˜ ์ˆ˜์ • ํ›„ Toastํ•จ์ˆ˜๋ฅผ UI๋‹จ์— ๋‘˜์ง€ ์•„๋‹ˆ๋ฉด common ๋ชจ๋“ˆ์— ๋‘˜์ง€ ๋…ผ์˜ํ•ด๋ด์•ผํ•  ๊ฑฐ ๊ฐ™๋„ค์š”!

@diejdkll diejdkll merged commit 6c26ba7 into develop Jun 3, 2024
1 check passed
@diejdkll diejdkll deleted the refactor/#208_add_toast_funtion branch June 3, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chaejongin12 Chaejongin12 Chaejongin12 approved these changes

@wjdcksdn wjdcksdn wjdcksdn approved these changes

Assignees

@diejdkll diejdkll

Labels
3๏ธโƒฃ Priority: Low ์šฐ์„ ์ˆœ์œ„ - ํ•˜ โ™ป๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toast ์ƒ์„ฑ ํ•จ์ˆ˜ ๋งŒ๋“ค๊ธฐ
3 participants
@diejdkll @wjdcksdn @Chaejongin12