Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔀 :: (#228) - Moshi 라이브러리 직렬화를 사용하여 Gson의 단점을 보완하였습니다 #230

Merged
merged 9 commits into from
Jun 19, 2024
Merged

🔀 :: (#228) - Moshi 라이브러리 직렬화를 사용하여 Gson의 단점을 보완하였습니다 #230

merged 9 commits into from
Jun 19, 2024

Conversation

audgns10
Copy link
Member

💡 개요

  • Moshi 라이브러리 직렬화로 성능개선

📃 작업내용

  • 라이브러리 추가
  • build.gradle.kts 파일에 추가
  • networkModule에 적용
  • Dto 각각 Request, Response에 적용

🔀 변경사항

  • chore libs.versions.toml
  • chore build.gradle.kts(network)
  • chore NetworkModule
  • chore Response, Request(network)

🙋‍♂️ 질문사항

🍴 사용방법

🎸 기타

@audgns10 audgns10 added 1️⃣ Priority: High 우선순위 - 상 ⚡️performance 성능 개선 ✨ Feature 신규 기능 labels Jun 19, 2024
@audgns10 audgns10 self-assigned this Jun 19, 2024
@audgns10 audgns10 linked an issue Jun 19, 2024 that may be closed by this pull request
moshi 라이브러리 직렬화 사용 #228
Closed
diejdkll
diejdkll reviewed Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@diejdkll diejdkll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

인터셉터도 gson -> moshi로 바꾸면 좋을거 같아요

audgns10
audgns10 commented Jun 19, 2024
View reviewed changes
Copy link
Member Author

@audgns10 audgns10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

02a24d8 이렇게 하는 방식이 맞는지 확인해주세요!

@audgns10 audgns10 merged commit 28fe2de into develop Jun 19, 2024
1 check passed
@audgns10 audgns10 deleted the feature/228-apply-moshi branch June 19, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chaejongin12 Chaejongin12 Chaejongin12 approved these changes

@wjdcksdn wjdcksdn wjdcksdn approved these changes

@diejdkll diejdkll diejdkll approved these changes

Assignees

@audgns10 audgns10

Labels
1️⃣ Priority: High 우선순위 - 상 ✨ Feature 신규 기능 ⚡️performance 성능 개선
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

moshi 라이브러리 직렬화 사용
4 participants
@audgns10 @diejdkll @wjdcksdn @Chaejongin12