Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#238) Fix Lecture Response Converter Error #239

Merged
merged 11 commits into from
Jul 17, 2024
Merged

๐Ÿ”€ :: (#238) Fix Lecture Response Converter Error #239

merged 11 commits into from
Jul 17, 2024

Conversation

Chaejongin12
Copy link
Collaborator

๐Ÿ’ก ๊ฐœ์š”

Lecture๋„๋ฉ”์ธ์˜ API๋ฅผ ๋™์ž‘ํ•˜๋˜์ค‘ Converter์—๋Ÿฌ๋ฅผ ๋ฐœ์ƒ์‹œ์ผœ API๊ฐ€ ๋™์ž‘ํ•˜์ง€ ์•Š์Œ

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

Moshi์˜ UUID ๋ณ€ํ™˜์„ ์œ„ํ•ด UUID ๋ณ€ํ™˜ ์–ด๋Œ‘ํ„ฐ๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
LectureListResponse๋ฅผ ๋ฐ˜ํ™˜๋ฐ›๋Š” ๊ณผ์ •์—์„œ transform๋ธ”๋Ÿญ ๋‚ด์˜ emit์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ”€ ๋ณ€๊ฒฝ์‚ฌํ•ญ

๊ธฐ์กด ํŽ˜์ด์ง• ํ•„๋“œ๊ฐ€ ์„ค์ • ๋˜์–ด์žˆ์ง€ ์•Š๋˜ LectureListResponse์˜ ํ•„๋“œ์— ํŽ˜์ด์ง• ํ•„๋“œ๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ™‹โ€โ™‚๏ธ ์งˆ๋ฌธ์‚ฌํ•ญ

์ปจ๋ฒค์…˜์— ๋งž์ง€ ์•Š๋Š” ๋ถ€๋ถ„์ด ์žˆ๊ฑฐ๋‚˜ ๋น„ํšจ์œจ์ ์ธ ์ฝ”๋“œ๊ฐ€ ์žˆ๋‹ค๋ฉด ๋ฆฌ๋ทฐ ๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค.

@Chaejongin12
โœจ:: LectureListMapper ํŽ˜์ด์ง• Mapper ์ถ”๊ฐ€
07a7d8e
@Chaejongin12
โœจ:: LectureRepository transform ๋ธ”๋Ÿญ๋‚ด data emit ์ถ”๊ฐ€
fffda0a
@Chaejongin12
๐Ÿ”ฅ:: GetLectureListUseCase invoke ํ•จ์ˆ˜ suspend ํ‚ค์›Œ๋“œ ์‚ญ์ œ
a6ce60b
@Chaejongin12
โœจ:: LectureListEntity ํŽ˜์ด์ง• ํ•„๋“œ ์ถ”๊ฐ€
98d0c6e
@Chaejongin12
โœจ:: LectureListResponse ํŽ˜์ด์ง• ํ•„๋“œ ์ถ”๊ฐ€
39f3639
@Chaejongin12
โ™ป๏ธ:: LectureStatus Enum ๋„ค์ด๋ฐ ์ˆ˜์ •
caa3672
@Chaejongin12
โ™ป๏ธ:: makeRequest emit ๊ฐœํ–‰
af8c531
@Chaejongin12
โœจ:: UUID Json ๋ณ€ํ™˜ Adapter ์ถ”๊ฐ€
28827fa
@Chaejongin12
โ™ป๏ธ:: feature Lecture Composable Response, Entity ํŽ˜์ด์ง• ์ฒ˜๋ฆฌ ํ•„๋“œ ์ถ”๊ฐ€๋กœ ์ธํ•œ ์ ‘๊ทผ ์ˆ˜
a4d7f87
@Chaejongin12
โ™ป๏ธ:: LectureDetailScreen LectureStatus Enum ๋„ค์ด๋ฐ ๋ณ€๊ฒฝ ์ ์šฉ
d32dd19
@Chaejongin12 Chaejongin12 added the 0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰!!!!! label Jul 17, 2024
@Chaejongin12 Chaejongin12 self-assigned this Jul 17, 2024
@Chaejongin12 Chaejongin12 linked an issue Jul 17, 2024 that may be closed by this pull request
๊ฐ•์˜ ์ „์ฒด ์กฐํšŒ์‹œ converter ์˜ค๋ฅ˜๊ฐ€ ๋ฐœ์ƒ #238
Closed
@Chaejongin12
๐Ÿ”ฅ :: LaunchedEffect Lecture Log ์‚ญ์ œ
7484160 
:: LaunchedEffect Lecture Log ์‚ญ์ œ
@Chaejongin12 Chaejongin12 merged commit f421967 into develop Jul 17, 2024
1 check passed
@Chaejongin12 Chaejongin12 deleted the fix/#238_fix_lecture_response_converter branch July 17, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjdcksdn wjdcksdn wjdcksdn approved these changes

@diejdkll diejdkll diejdkll approved these changes

@audgns10 audgns10 Awaiting requested review from audgns10

Assignees

@Chaejongin12 Chaejongin12

Labels
0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰!!!!!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

๊ฐ•์˜ ์ „์ฒด ์กฐํšŒ์‹œ converter ์˜ค๋ฅ˜๊ฐ€ ๋ฐœ์ƒ
3 participants
@Chaejongin12 @diejdkll @wjdcksdn