Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (#294) - Use UiState To Certification Module #295

Merged
merged 149 commits into from
Nov 30, 2024
Merged

๐Ÿ”€ :: (#294) - Use UiState To Certification Module #295

merged 149 commits into from
Nov 30, 2024

Conversation

audgns10
Copy link
Member

@audgns10 audgns10 commented Sep 9, 2024

๐Ÿ’ก ๊ฐœ์š”

  • Certification ๋ชจ๋“ˆ์—์„œ UiState๋กœ ๊ด€๋ฆฌ๋ฅผ ํ•˜๋Š” ๊ฒƒ์ด ํ”„๋กœ์ ํŠธ ์ƒ์—์„œ ๋” ์•ˆ์ •์ ์œผ๋กœ ๋ณด์—ฌ UiState๋ฅผ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ๋„๋ก Migration์„ ์ง„ํ–‰ํ•ฉ๋‹ˆ๋‹ค.

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • Certification ๋ชจ๋“ˆ์„ UiState๋กœ Migration ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
    • asResult() ํ•จ์ˆ˜๋ฅผ ์ •์˜ํ•˜์—ฌ viewModel์—์„œ UiState์˜ ์ƒํƒœ๋ฅผ ๊ด€๋ฆฌํ•˜๊ธฐ ๋” ์‰ฝ๋„๋ก ํ•˜์˜€์Šต๋‹ˆ๋‹ค
    • ๋ถˆํ•„์š”ํ•œ suspend ํ‚ค์›Œ๋“œ๋ฅผ ์‚ญ์ œํ•˜์˜€์Šต๋‹ˆ๋‹ค. / Flow๋ฅผ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ๋„๋ก ๋ณ€๊ฒฝํ•˜์˜€์Šต๋‹ˆ๋‹ค.(UseCase)
    • UiState๋ฅผ ๋งŒ๋“ค์—ˆ์Šต๋‹ˆ๋‹ค. -> ์ด๋ฅผ viewModel์— ์ ์šฉ -> viewModel ์ ์šฉ ์ดํ›„ Screen์— ์ ์šฉ
    • ๋ถˆํ•„์š”ํ•œ ์ฝ”๋“œ๋ฅผ ์‚ญ์ œํ•˜์˜€์Šต๋‹ˆ๋‹ค.

๐Ÿ”€ ๋ณ€๊ฒฝ์‚ฌํ•ญ

  • add result.kt - asResult()
  • refactor GetCertificationListUseCase
  • refactor WriteCertificationUseCase
  • refactor EditCertificationUseCase
  • refactor GetStudentBelongClubUseCase
  • refactor GetLectureSignUpHistoryUseCase
  • add EditCertificationUiState
  • add GetCertificationListUiState
  • add GetLectureSignUpHistoryUiState
  • add GetStudentBelongClubDetailUiState
  • add WriteCertificationUiState
  • refactor CertificationViewModel
  • refactor AddCertificationScreen
  • refactor CertificationScreen

๐Ÿ™‹โ€โ™‚๏ธ ์งˆ๋ฌธ์‚ฌํ•ญ

  • ์—”์ง€๋ฝ์ด ์ฃฝ์€ ๊ฒƒ ๊ฐ™์•„ ํ…Œ์ŠคํŠธ๋Š” ๋ชปํ•ด๋ดค์ง€๋งŒ ๋‹ค์‹œ ์‚ด์•„๋‚˜๋ฉด ํ…Œ์ŠคํŠธ ํ›„ ๋จธ์ง€ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค. ์ผ๋‹จ pr ์˜ฌ๋ฆฌ๊ฒ ์Šต๋‹ˆ๋‹ค.

๐Ÿด ์‚ฌ์šฉ๋ฐฉ๋ฒ•

  • x

๐ŸŽธ ๊ธฐํƒ€

  • x

@audgns10
โœจ :: Create asResult() Function(Use ViewModel - UiState)
7c1f612
@audgns10
๐Ÿ”ฅ :: Fire Unused Import
532eac0
@audgns10
๐Ÿ”ฅ :: Unused Code(File)
37c632a
@audgns10
โ™ป๏ธ :: Combine The Use Cases Into One
bd67678
@audgns10
โœจ :: Create GetCertificationListUiState
2d55ff6
@audgns10
โ™ป๏ธ :: Simplify ViewModel Code And Apply UiState
f77bb0f
@audgns10
โ™ป๏ธ :: Apply ViewModel Changed(Apply UiState)
946d74e
@audgns10
โ™ป๏ธ :: Simplify ViewModel Code And Apply UiState - getCertificationLisโ€ฆ
19c1a63 
โ€ฆt Function
@audgns10
โ™ป๏ธ :: Apply ViewModel Changed(Apply UiState)
559e7a2
@audgns10
Merge branch 'refactor/294-use-uistate-to-certification-module' of htโ€ฆ
6824bb4 
โ€ฆtps://github.com/School-of-Company/Bitgoeul-Android into refactor/294-use-uistate-to-certification-module
@audgns10
๐Ÿ”ฅ :: Line Spacing
95d670e
@audgns10
๐Ÿ“ :: Modify Use Flow And Fire Unused Code
65517f2
@audgns10
โœจ :: Create GetLectureSignUpHistoryUiState
7ceb43b
@audgns10
โ™ป๏ธ :: Changed TextStyle And Color && Apply UiState To Screen
5686d41
@audgns10
โ™ป๏ธ :: Apply UiState To CertificationViewModel(getLectureSignUpHistory)
d380add
@audgns10
โ™ป๏ธ :: Use Flow To WriteCertificationUseCase
a31bd09
@audgns10
โœจ :: Create WriteCertificationUiState
a2d13ac
@audgns10
โ™ป๏ธ :: Apply WriteCertificationUiState To CertificationViewModel
0768955
@audgns10
๐Ÿ“ :: Add strings.xml To Other Strings
47f2da4
@audgns10
โž• :: Add Implementation To build.gradle.kts(:app)
ff10373
@audgns10
โœจ :: Create errorToast(BitgoeulNavHost)
b761769
@audgns10
โ™ป๏ธ :: Use Flow - EditCertificationUseCase
4a1fdd8
@audgns10
โ™ป๏ธ :: Use Coroutine Flow - EditCertificationUseCase
3939251
@audgns10
โ™ป๏ธ :: Use Coroutine Flow(GetStudentBelongClubUseCase)
0b11882
@audgns10
Merge branch 'refactor/294-use-uistate-to-certification-module' of htโ€ฆ
54b2a1a 
โ€ฆtps://github.com/School-of-Company/Bitgoeul-Android into refactor/294-use-uistate-to-certification-module
@audgns10
๐Ÿ”ฅ :: Fire Unused Import
78b3c20
@audgns10
โœจ :: Create GetStudentBelongClubDetailUiState
d21c9ef
@audgns10
โœจ :: Create EditCertificationUiState
c382f80
@audgns10
โ™ป๏ธ :: Apply createErrorToast To Certification Navigation
775271b
@audgns10
โ™ป๏ธ :: Use data class - GetCertificationListUiState
668dfc5
@audgns10
โ™ป๏ธ :: Apply UiState To CertificationViewModel(getLectureSignUpHistory)
905c21f
@audgns10
โ™ป๏ธ :: Use Flow To WriteCertificationUseCase
d7c0b5c
@audgns10
โœจ :: Create WriteCertificationUiState
4903d84
@audgns10
โ™ป๏ธ :: Apply WriteCertificationUiState To CertificationViewModel
3286f56
@audgns10
๐Ÿ“ :: Add strings.xml To Other Strings
792c1f7
@audgns10
โž• :: Add Implementation To build.gradle.kts(:app)
606abea
@audgns10
โœจ :: Create errorToast(BitgoeulNavHost)
fb13703
@audgns10
โ™ป๏ธ :: Use Coroutine Flow - EditCertificationUseCase
4424640
@audgns10
โ™ป๏ธ :: Use Coroutine Flow(GetStudentBelongClubUseCase)
3569b63
@audgns10
๐Ÿ”ฅ :: Fire Unused Import
b750378
@audgns10
โœจ :: Create GetStudentBelongClubDetailUiState
e001b7c
@audgns10
โœจ :: Create EditCertificationUiState
8b159e9
@audgns10
โ™ป๏ธ :: Apply createErrorToast To Certification Navigation
2f55889
@audgns10
โ™ป๏ธ :: Use data class State Error - GetCertificationListUiState
21019eb
@audgns10
โ™ป๏ธ :: Use data class State Error - GetLectureSignUpHistoryUiState
828e380
@audgns10
โ™ป๏ธ :: Apply Before Changed(Apply UiState, Changed Logic) - Certificatโ€ฆ
1121a1c 
โ€ฆionViewModel
@audgns10
๐Ÿ”ฅ :: Fire Unused State(Loading) - WriteCertificationUiState
d34336d
@audgns10
โ™ป๏ธ :: Apply ViewModel Changed(Check Before Commit)
8f76f47
@audgns10
โ™ป๏ธ :: Apply ViewModel Changed And Change Logic
2b05a7e
@audgns10
โ™ป๏ธ :: Fire Line Spacing And Changed Error State Logic
302a1d9
@audgns10
โ™ป๏ธ :: Add createErrorToast
3f90b1d
@audgns10
๐Ÿ”ฅ :: Fire Unused Import
0b9dcbc
@audgns10
๐Ÿ”ฅ :: Fire Line Spacing
89be535
@audgns10
โ™ป๏ธ :: Apply Before Changed(Apply UiState, Changed Logic) - Certificatโ€ฆ
3216bea 
โ€ฆionViewModel
@audgns10
๐Ÿ”ฅ :: Fire Line Spacing
ee7d9b4
@audgns10
Merge branch 'refactor/294-use-uistate-to-certification-module' of htโ€ฆ
91e18fd 
โ€ฆtps://github.com/School-of-Company/Bitgoeul-Android into refactor/294-use-uistate-to-certification-module
@audgns10
โ™ป๏ธ :: Improve Code Readability(Apply Reviewer)
0773190
@audgns10 audgns10 merged commit 7c44705 into develop Nov 30, 2024
1 check passed
@audgns10 audgns10 deleted the refactor/294-use-uistate-to-certification-module branch November 30, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minStone-dev minStone-dev minStone-dev left review comments

@Ethen1264 Ethen1264 Ethen1264 approved these changes

@Chaejongin12 Chaejongin12 Chaejongin12 approved these changes

@wjdcksdn wjdcksdn wjdcksdn approved these changes

@diejdkll diejdkll diejdkll approved these changes

Assignees

@audgns10 audgns10

Labels
2๏ธโƒฃ Priority: Medium ์šฐ์„ ์ˆœ์œ„ - ์ค‘ โ™ป๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง
Projects
None yet
Milestone
No milestone
6 participants
@audgns10 @diejdkll @wjdcksdn @Chaejongin12 @minStone-dev @Ethen1264