Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: 503 test/university domain test code #509

Merged
merged 3 commits into from
Jul 8, 2024
Merged

๐Ÿ”€ :: 503 test/university domain test code #509

merged 3 commits into from
Jul 8, 2024

Conversation

KimTaeO
Copy link
Collaborator

@KimTaeO KimTaeO commented Jul 8, 2024

๐Ÿ’ก ๋ฐฐ๊ฒฝ ๋ฐ ๊ฐœ์š”

university domain์˜ ์„œ๋น„์Šค ์ฝ”๋“œ๋ฅผ ์ž‘์„ฑํ–ˆ์Šต๋‹ˆ๋‹ค

Resolves: #503

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

์„œ๋น„์Šค ์ฝ”๋“œ์˜ createUniversity, updateUniversity, queryUniversities์˜ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ๋ฅผ ์ž‘์„ฑํ•˜์˜€์Šต๋‹ˆ๋‹ค

โœ… PR ์ฒดํฌ๋ฆฌ์ŠคํŠธ

ํ…œํ”Œ๋ฆฟ ์ฒดํฌ๋ฆฌ์ŠคํŠธ ๋ง๊ณ ๋„ ์ถ”๊ฐ€์ ์œผ๋กœ ํ•„์š”ํ•œ ์ฒดํฌ๋ฆฌ์ŠคํŠธ๋Š” ์ถ”๊ฐ€ํ•ด์ฃผ์„ธ์š”!

  • ์ด ์ž‘์—…์œผ๋กœ ์ธํ•ด ๋ณ€๊ฒฝ์ด ํ•„์š”ํ•œ ๋ฌธ์„œ๊ฐ€ ๋ณ€๊ฒฝ๋˜์—ˆ๋‚˜์š”? (e.g. .env, ๋…ธ์…˜, README)
  • ์ด ์ž‘์—…์„ ํ•˜๊ณ ๋‚˜์„œ ๊ณต์œ ํ•ด์•ผํ•  ํŒ€์›๋“ค์—๊ฒŒ ๊ณต์œ ๋˜์—ˆ๋‚˜์š”? (e.g. "API ๊ฐœ๋ฐœ ์™„๋ฃŒ๋์–ด์š”", "ํ™˜๊ฒฝ๊ฐ’ ์ถ”๊ฐ€๋˜์—ˆ์–ด์š”")
  • ์ž‘์—…ํ•œ ์ฝ”๋“œ๊ฐ€ ์ •์ƒ์ ์œผ๋กœ ๋™์ž‘ํ•˜๋‚˜์š”?
  • Merge ๋Œ€์ƒ ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€์š”?
  • PR๊ณผ ๊ด€๋ จ ์—†๋Š” ์ž‘์—…์ด ์žˆ์ง€๋Š” ์•Š๋‚˜์š”?

๐ŸŽธ ๊ธฐํƒ€

@KimTaeO KimTaeO added the โœ… Test Test๊ด€๋ จ์‚ฌํ•ญ label Jul 8, 2024
@KimTaeO KimTaeO self-assigned this Jul 8, 2024
@KimTaeO KimTaeO requested review from JuuuuHong and ani2689 as code owners July 8, 2024 13:39
@KimTaeO KimTaeO linked an issue Jul 8, 2024 that may be closed by this pull request
๋Œ€ํ•™ ๋„๋ฉ”์ธ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ #503
Closed
ani2689
ani2689 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@ani2689 ani2689 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿ‘

@KimTaeO KimTaeO merged commit 742cff4 into master Jul 8, 2024
1 check passed
@KimTaeO KimTaeO deleted the 503-test/university-domain-test-code branch July 8, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ani2689 ani2689 ani2689 approved these changes

@JuuuuHong JuuuuHong JuuuuHong approved these changes

Assignees

@KimTaeO KimTaeO

Labels
โœ… Test Test๊ด€๋ จ์‚ฌํ•ญ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

๋Œ€ํ•™ ๋„๋ฉ”์ธ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ
3 participants
@KimTaeO @JuuuuHong @ani2689