# 572 전체 취업 동아리 엑셀 출력 #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ani2689
reviewed
Sep 1, 2024
|
|
||
| val creationHelper = workBook.creationHelper | ||
| val hyperlink = creationHelper.createHyperlink(HyperlinkType.URL) | ||
| hyperlink.address = "https://bitgouel-admin.vercel.app/main/club/detail/${club.id}" |
There was a problem hiding this comment.
프론트 링크가 변경될 수 있으니 환경변수로 처리하는 건 어떨까요?
ani2689
approved these changes
Sep 1, 2024
KimTaeO
reviewed
Sep 1, 2024
| val grade2ndStudentCount = studentRepository.countByClubAndGrade(club, 2) | ||
| row.createCellWithOptions(8, grade2ndStudentCount.toString(), defaultStyle) | ||
|
|
||
| val grade3ndStudentCount = studentRepository.countByClubAndGrade(club, 3) |
There was a problem hiding this comment.
3rd로 표기하는게 맞아보여요
그리고 문법적으로 본다면 3rdGradeXXX가 조금 더 적절하지 않나 싶어요
There was a problem hiding this comment.
9074f6b 변수 선언 시 숫자가 앞으로 갈 수 없어서 grade3rdStudentCount 로만 변경해 주었습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 배경 및 개요
전체 취업 동아리 엑셀 출력
Resolves: #572
📃 작업내용
출력했을 때 나오는 엑셀 형식입니다. 디자인적인 요소는 장학사님과 이야기하면서 개선해 나가겠습니다.