Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ”€ :: (#236) - ํ”„๋กœ๊ทธ๋žจ ๊ด€๋ฆฌ ํŽ˜์ด์ง€์˜ UI๊ฐ€ ๋””์ž์ธ ์š”๊ตฌ์‚ฌํ•ญ๊ณผ ๋งž์ง€์•Š์€ ๋ถ€๋ถ„์ด ์กด์žฌํ•˜์—ฌ ํ•ด๋‹น ๋ถ€๋ถ„์„ ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค. #237

Merged

Conversation

audgns10
Copy link
Member

@audgns10 audgns10 commented Dec 11, 2024

๐Ÿ’ก ๊ฐœ์š”

  • ํ”„๋กœ๊ทธ๋žจ ๊ด€๋ฆฌ ํŽ˜์ด์ง€์˜ UI๊ฐ€ ๋””์ž์ธ ์š”๊ตฌ์‚ฌํ•ญ๊ณผ ๋งž์ง€์•Š์€ ๋ถ€๋ถ„์ด ์กด์žฌํ•˜์—ฌ ํ•ด๋‹น ๋ถ€๋ถ„์ด ์ˆ˜์ •์ด ํ•„์š”ํ•ด๋ณด์˜€์Šต๋‹ˆ๋‹ค.

๐Ÿ“ƒ ์ž‘์—…๋‚ด์šฉ

  • ํ”„๋กœ๊ทธ๋žจ ๊ด€๋ฆฌ ํŽ˜์ด์ง€์˜ UI๊ฐ€ ๋””์ž์ธ ์š”๊ตฌ์‚ฌํ•ญ๊ณผ ๋งž์ง€์•Š์€ ๋ถ€๋ถ„์ด ์กด์žฌํ•˜์—ฌ ํ•ด๋‹น ๋ถ€๋ถ„์„ ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

    • ๋ฆฌ์ŠคํŠธ ์•„์ดํ…œ ๋””์ž์ธ ์ˆ˜์ •
    2024-12-11.11.26.28.mov

๐Ÿ”€ ๋ณ€๊ฒฝ์‚ฌํ•ญ

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-12-11 แ„‹แ…ฉแ„’แ…ฎ 11 17 51

๐Ÿ™‹โ€โ™‚๏ธ ์งˆ๋ฌธ์‚ฌํ•ญ

  • ๊ฐœ์„ ํ•  ์ , ์˜คํƒ€, ์ฝ”๋“œ์— ์ด์ƒํ•œ ๋ถ€๋ถ„์ด ์žˆ๋‹ค๋ฉด Comment ๋‹ฌ์•„์ฃผ์„ธ์š”.

๐Ÿด ์‚ฌ์šฉ๋ฐฉ๋ฒ•

  • x

๐ŸŽธ ๊ธฐํƒ€

  • x

Summary by CodeRabbit

  • New Features

    • UI ๊ฐœ์„ : HomeDetailProgramParticipantScreen ๋ฐ HomeDetailProgramScreen์˜ ๋ ˆ์ด์•„์›ƒ๊ณผ ๊ธฐ๋Šฅ ํ–ฅ์ƒ.
    • ๋™์  ๋ ˆ์ด์•„์›ƒ ์ถ”๊ฐ€: ํ”„๋กœ๊ทธ๋žจ ์„ธ๋ถ€์ •๋ณด ํ™”๋ฉด์— ์‹œ์ž‘ ์‹œ๊ฐ„ ๋ฐ ์ข…๋ฃŒ ์‹œ๊ฐ„ ํ•„๋“œ ํฌํ•จ.
    • ์˜ค๋ฅ˜ ์ฒ˜๋ฆฌ ๊ฐœ์„ : ๋ฐ์ดํ„ฐ๊ฐ€ ์—†๊ฑฐ๋‚˜ ์˜ค๋ฅ˜๊ฐ€ ๋ฐœ์ƒํ•  ๊ฒฝ์šฐ ์‚ฌ์šฉ์ž์—๊ฒŒ ๋ช…ํ™•ํ•œ ํ”ผ๋“œ๋ฐฑ ์ œ๊ณต.
    • ์ƒˆ๋กœ์šด ๋ฏธ๋ฆฌ๋ณด๊ธฐ ํ•จ์ˆ˜ ์ถ”๊ฐ€๋กœ UI ํ…Œ์ŠคํŠธ ์šฉ์ด์„ฑ ์ฆ๊ฐ€.
    • ์ˆ˜ํ‰ ์Šคํฌ๋กค ๊ธฐ๋Šฅ ์ถ”๊ฐ€: ์—ฌ๋Ÿฌ UI ์ปดํฌ๋„ŒํŠธ์—์„œ ์ˆ˜ํ‰ ์Šคํฌ๋กค ์ง€์›.
  • Bug Fixes

    • ์Šคํฌ๋กค ๋™์ž‘ ๋ฐ UI ์š”์†Œ ๊ฐ„์˜ ๊ฐ„๊ฒฉ ์กฐ์ •์œผ๋กœ ์‚ฌ์šฉ์ž ๊ฒฝํ—˜ ํ–ฅ์ƒ.

Copy link

coderabbitai bot commented Dec 11, 2024

Warning

Rate limit exceeded

@audgns10 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 29 minutes and 1 seconds before requesting another review.

โŒ› How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

๐Ÿšฆ How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 129730e and a0140e2.

๐Ÿ“’ Files selected for processing (1)
  • feature/home/src/main/java/com/school_of_company/home/view/component/StandardProgramListItem.kt (3 hunks)

Walkthrough

์ด ๋ณ€๊ฒฝ ์‚ฌํ•ญ์€ HomeDetailProgramParticipantScreen.kt, HomeDetailProgramScreen.kt, HomeDetailProgramParticipantListItem.kt, ProgramList.kt, ProgramListItem.kt, ProgramTabRowItem.kt, ๋ฐ StandardProgramListItem.kt ํŒŒ์ผ์˜ UI ๊ตฌ์„ฑ ์š”์†Œ์™€ ๊ธฐ๋Šฅ์„ ํ–ฅ์ƒ์‹œํ‚ค๋Š” ์—ฌ๋Ÿฌ ์ˆ˜์ •์„ ํฌํ•จํ•ฉ๋‹ˆ๋‹ค. ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ์œผ๋กœ๋Š” ์ƒˆ๋กœ์šด ๋งค๊ฐœ๋ณ€์ˆ˜ ์ถ”๊ฐ€, ๋ ˆ์ด์•„์›ƒ ์กฐ์ •, ์˜ค๋ฅ˜ ์ฒ˜๋ฆฌ ๊ฐœ์„ , ๋ฏธ๋ฆฌ๋ณด๊ธฐ ๊ธฐ๋Šฅ ์—…๋ฐ์ดํŠธ ๋“ฑ์ด ์žˆ์Šต๋‹ˆ๋‹ค. ์ด๋Ÿฌํ•œ ์ˆ˜์ •์€ ์‚ฌ์šฉ์ž ์ธํ„ฐํŽ˜์ด์Šค์˜ ๊ฐ€๋…์„ฑ๊ณผ ์‚ฌ์šฉ์„ฑ์„ ๋†’์ด๋Š” ๋ฐ ์ค‘์ ์„ ๋‘๊ณ  ์žˆ์œผ๋ฉฐ, ๊ธฐ๋ณธ์ ์ธ ๋กœ์ง์ด๋‚˜ ๋ฐ์ดํ„ฐ ํ๋ฆ„์€ ์œ ์ง€๋˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค.

Changes

ํŒŒ์ผ ๊ฒฝ๋กœ ๋ณ€๊ฒฝ ์š”์•ฝ
.../HomeDetailProgramParticipantScreen.kt Row์˜ ์ˆ˜ํ‰ ๋ฐฐ์น˜ ์กฐ์ • ๋ฐ ์ƒˆ๋กœ์šด ๊ฐ„๊ฒฉ ๋งค๊ฐœ๋ณ€์ˆ˜ ์ถ”๊ฐ€. HomeDetailProgramParticipantScreenPreview ํ•จ์ˆ˜ ์—…๋ฐ์ดํŠธ.
.../HomeDetailProgramScreen.kt id ๋งค๊ฐœ๋ณ€์ˆ˜ ์ œ๊ฑฐ ๋ฐ scrollState ๋งค๊ฐœ๋ณ€์ˆ˜ ์ถ”๊ฐ€. UI ๋ ˆ์ด์•„์›ƒ ๊ฐœ์„  ๋ฐ ์˜ค๋ฅ˜ ์ฒ˜๋ฆฌ ๋ฉ”์‹œ์ง€ ์ถ”๊ฐ€.
.../HomeDetailProgramParticipantListItem.kt Row์— horizontalArrangement ๋งค๊ฐœ๋ณ€์ˆ˜ ์ถ”๊ฐ€. ๋ฏธ๋ฆฌ๋ณด๊ธฐ ๊ธฐ๋Šฅ ์—…๋ฐ์ดํŠธ.
.../ProgramList.kt ์ƒˆ๋กœ์šด ๋ฏธ๋ฆฌ๋ณด๊ธฐ ํ•จ์ˆ˜ ProgramListPreview ์ถ”๊ฐ€.
.../ProgramListItem.kt horizontalScrollState ๋งค๊ฐœ๋ณ€์ˆ˜ ์ถ”๊ฐ€ ๋ฐ ๋ ˆ์ด์•„์›ƒ ์ˆ˜์ •. ๋ฏธ๋ฆฌ๋ณด๊ธฐ ๊ธฐ๋Šฅ ์—…๋ฐ์ดํŠธ.
.../ProgramTabRowItem.kt Text ์ƒ‰์ƒ ๋งค๊ฐœ๋ณ€์ˆ˜ ๋ณ€๊ฒฝ.
.../StandardProgramListItem.kt horizontalScrollState ๋งค๊ฐœ๋ณ€์ˆ˜ ์ถ”๊ฐ€ ๋ฐ ๋ ˆ์ด์•„์›ƒ ์ˆ˜์ •. ๋ฏธ๋ฆฌ๋ณด๊ธฐ ๊ธฐ๋Šฅ ์ถ”๊ฐ€.

Possibly related PRs

Suggested labels

โœจ Feature

Suggested reviewers

  • diejdkll
  • Chaejongin12
  • kimjeakwan

๐Ÿฐ ๋ณ€ํ™”์˜ ๋ฐ”๋žŒ์ด ๋ถˆ์–ด์™€
ํ™ˆ ํ™”๋ฉด์ด ๋”์šฑ ๋น›๋‚˜๋„ค!
๊ตฌ์„ฑ ์š”์†Œ๊ฐ€ ์ƒˆ๋กญ๊ฒŒ ํƒœ์–ด๋‚˜
์‚ฌ์šฉ์ž์—๊ฒŒ ๊ธฐ์จ์„ ์ฃผ๋ฆฌ๋ผ!
ํ•จ๊ป˜ํ•˜๋Š” ๋ชจ๋“  ์ˆœ๊ฐ„์ด
์ฆ๊ฑฐ์šด ๊ฒฝํ—˜์ด ๋˜๊ธฐ๋ฅผ! ๐ŸŒผ


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

โค๏ธ Share
๐Ÿชง Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@audgns10 audgns10 changed the title ๐Ÿ”€ :: (#236) - ํ”„๋กœ๊ทธ๋žจ ๊ด€๋ฆฌ ํŽ˜์ด์ง€์˜ UI๊ฐ€ ๋””์ž์ธ ์š”๊ตฌ์‚ฌํ•ญ๊ณผ ๋งž์ง€์•Š์€ ๋ถ€๋ถ„์ด ์กด์žฌํ•˜์—ฌ ํ•ด๋‹น ๋ถ€๋ถ„์„ ์ˆ˜์ •ํ•ฉ๋‹ˆ๋‹ค ๐Ÿ”€ :: (#236) - ํ”„๋กœ๊ทธ๋žจ ๊ด€๋ฆฌ ํŽ˜์ด์ง€์˜ UI๊ฐ€ ๋””์ž์ธ ์š”๊ตฌ์‚ฌํ•ญ๊ณผ ๋งž์ง€์•Š์€ ๋ถ€๋ถ„์ด ์กด์žฌํ•˜์—ฌ ํ•ด๋‹น ๋ถ€๋ถ„์„ ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค. Dec 11, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

๐Ÿงน Outside diff range and nitpick comments (8)
feature/home/src/main/java/com/school_of_company/home/view/component/HomeDetailProgramParticipantListItem.kt (2)

84-96: Preview ํ•จ์ˆ˜์˜ ๊ฐœ์„ ์‚ฌํ•ญ์„ ์ œ์•ˆ๋“œ๋ฆฝ๋‹ˆ๋‹ค.

Preview ํ•จ์ˆ˜๊ฐ€ ์ž˜ ๊ตฌํ˜„๋˜์—ˆ์ง€๋งŒ, ๋‹ค์Œ๊ณผ ๊ฐ™์€ ๊ฐœ์„ ์‚ฌํ•ญ์„ ๊ณ ๋ คํ•ด๋ณด์‹œ๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค:

  • ๋‹ค์–‘ํ•œ ๊ธธ์ด์˜ ๋ฐ์ดํ„ฐ๋กœ ํ…Œ์ŠคํŠธ
  • Dark ํ…Œ๋งˆ Preview ์ถ”๊ฐ€

๋‹ค์Œ๊ณผ ๊ฐ™์ด ์ˆ˜์ •ํ•ด๋ณด์‹œ๋Š” ๊ฑด ์–ด๋–จ๊นŒ์š”?:

 @Preview
 @Composable
-private fun HomeDetailProgramParticipantListItemPreview() {
+private fun HomeDetailProgramParticipantListItemPreview() {
+    HomeDetailProgramParticipantListItem(
+        index = 1,
+        data = TeacherTrainingProgramResponseEntity(
+            id = 0,
+            name = "ํ™๊ธธ๋™",
+            organization = "ํ•œ๊ตญ๋Œ€ํ•™๊ต",
+            position = "๊ต์‚ฌ",
+            programName = "ํ”„๋กœ๊ทธ๋žจ",
+            status = true,
+            entryTime = "2024-09-12 T 08:30",
+            leaveTime = "2024-09-12 T 08:30"
+        )
+    )
+}
+
+@Preview(name = "๊ธด ํ…์ŠคํŠธ")
+@Composable
+private fun HomeDetailProgramParticipantListItemLongTextPreview() {
+    HomeDetailProgramParticipantListItem(
+        index = 1,
+        data = TeacherTrainingProgramResponseEntity(
+            id = 0,
+            name = "๊น€๋งค์šฐ๊ธด์ด๋ฆ„",
+            organization = "๋งค์šฐ๊ธดํ•™๊ต์ด๋ฆ„๋Œ€ํ•™๊ต",
+            position = "์ˆ˜์„๊ต์‚ฌ",
+            programName = "๋งค์šฐ ๊ธด ํ”„๋กœ๊ทธ๋žจ ์ด๋ฆ„์ž…๋‹ˆ๋‹ค",
+            status = true,
+            entryTime = "2024-09-12 T 08:30",
+            leaveTime = "2024-09-12 T 08:30"
+        )
+    )
+}
+
+@Preview(name = "Dark Theme")
+@Composable
+private fun HomeDetailProgramParticipantListItemDarkPreview() {
+    ExpoAndroidTheme(darkTheme = true) {
+        HomeDetailProgramParticipantListItem(
+            index = 1,
+            data = TeacherTrainingProgramResponseEntity(
+                id = 0,
+                name = "ํ™๊ธธ๋™",
+                organization = "ํ•œ๊ตญ๋Œ€ํ•™๊ต",
+                position = "๊ต์‚ฌ",
+                programName = "ํ”„๋กœ๊ทธ๋žจ",
+                status = true,
+                entryTime = "2024-09-12 T 08:30",
+                leaveTime = "2024-09-12 T 08:30"
+            )
+        )
+    }
+}

Line range hint 1-96: ํ•˜๋“œ์ฝ”๋”ฉ๋œ ๊ฐ’๋“ค์˜ ์ถ”์ƒํ™”๊ฐ€ ํ•„์š”ํ•ด ๋ณด์ž…๋‹ˆ๋‹ค.

์ปดํฌ๋„ŒํŠธ ๋‚ด์˜ ํ•˜๋“œ์ฝ”๋”ฉ๋œ ๊ฐ’๋“ค(width, ์ „ํ™”๋ฒˆํ˜ธ ๋“ฑ)์„ ์ƒ์ˆ˜๋‚˜ ์„ค์ •์œผ๋กœ ๋ถ„๋ฆฌํ•˜๋Š” ๊ฒƒ์ด ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

๋‹ค์Œ๊ณผ ๊ฐ™์€ ๊ฐœ์„ ์„ ์ œ์•ˆ๋“œ๋ฆฝ๋‹ˆ๋‹ค:

+private object Dimensions {
+    val INDEX_WIDTH = 20.dp
+    val NAME_WIDTH = 80.dp
+    val ORGANIZATION_WIDTH = 100.dp
+    val POSITION_WIDTH = 80.dp
+    val ROLE_WIDTH = 120.dp
+    val PHONE_WIDTH = 100.dp
+    val VERTICAL_PADDING = 8.dp
+    val ITEM_SPACING = 20.dp
+}

 @Composable
 fun HomeDetailProgramParticipantListItem(
     modifier: Modifier = Modifier,
     index: Int,
     data: TeacherTrainingProgramResponseEntity,
     horizontalScrollState: ScrollState = rememberScrollState()
 ) {
     ExpoAndroidTheme { colors, typography ->
-        Spacer(modifier = Modifier.height(20.dp))
+        Spacer(modifier = Modifier.height(Dimensions.ITEM_SPACING))
 
         Row(
             verticalAlignment = Alignment.CenterVertically,
-            horizontalArrangement = Arrangement.spacedBy(20.dp),
+            horizontalArrangement = Arrangement.spacedBy(Dimensions.ITEM_SPACING),
             modifier = modifier
                 .fillMaxWidth()
-                .padding(vertical = 8.dp)
+                .padding(vertical = Dimensions.VERTICAL_PADDING)
                 .horizontalScroll(horizontalScrollState)
         ) {
             Text(
                 text = index.toString(),
                 style = typography.captionRegular2,
                 color = colors.black,
-                modifier = Modifier.width(20.dp)
+                modifier = Modifier.width(Dimensions.INDEX_WIDTH)
             )
             // ... ๋‚˜๋จธ์ง€ Text ์ปดํฌ๋„ŒํŠธ๋“ค๋„ ๊ฐ™์€ ๋ฐฉ์‹์œผ๋กœ ์ˆ˜์ •
         }
     }
 }
feature/home/src/main/java/com/school_of_company/home/view/HomeDetailProgramParticipantScreen.kt (1)

259-267: ํ”„๋ฆฌ๋ทฐ ํ•จ์ˆ˜๊ฐ€ ์ ์ ˆํ•˜๊ฒŒ ๊ตฌํ˜„๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

๋ชจ๋“  ํ•„์ˆ˜ ๋งค๊ฐœ๋ณ€์ˆ˜๊ฐ€ ํฌํ•จ๋˜์–ด ์žˆ๊ณ , Loading ์ƒํƒœ๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ํ”„๋ฆฌ๋ทฐ๋ฅผ ๊ตฌํ˜„ํ•œ ๊ฒƒ์ด ์ ์ ˆํ•ฉ๋‹ˆ๋‹ค. ๋‹ค๋งŒ, ๋‹ค์–‘ํ•œ ์ƒํƒœ์— ๋Œ€ํ•œ ํ”„๋ฆฌ๋ทฐ๋„ ์ถ”๊ฐ€ํ•˜๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.

๋‹ค์Œ๊ณผ ๊ฐ™์ด ๋‹ค์–‘ํ•œ ์ƒํƒœ์˜ ํ”„๋ฆฌ๋ทฐ๋ฅผ ์ถ”๊ฐ€ํ•˜๋Š” ๊ฒƒ์„ ๊ณ ๋ คํ•ด๋ณด์„ธ์š”:

@Preview(name = "์„ฑ๊ณต ์ƒํƒœ")
@Composable
private fun HomeDetailProgramParticipantScreenSuccessPreview() {
    HomeDetailProgramParticipantScreen(
        id = 0,
        onBackClick = {},
        teacherTrainingProgramListUiState = TeacherTrainingProgramListUiState.Success(
            listOf(/* ์ƒ˜ํ”Œ ๋ฐ์ดํ„ฐ */)
        ),
        swipeRefreshState = rememberSwipeRefreshState(isRefreshing = false),
        getTeacherTrainingProgramList = {},
        navigateToQrScanner = { _, _ -> },
        traineeId = 1L
    )
}

@Preview(name = "๋นˆ ์ƒํƒœ")
@Composable
private fun HomeDetailProgramParticipantScreenEmptyPreview() {
    HomeDetailProgramParticipantScreen(
        id = 0,
        onBackClick = {},
        teacherTrainingProgramListUiState = TeacherTrainingProgramListUiState.Empty,
        swipeRefreshState = rememberSwipeRefreshState(isRefreshing = false),
        getTeacherTrainingProgramList = {},
        navigateToQrScanner = { _, _ -> },
        traineeId = -1L
    )
}
feature/home/src/main/java/com/school_of_company/home/view/HomeDetailProgramScreen.kt (3)

241-284: Empty์™€ Error ์ƒํƒœ UI ์ปดํฌ๋„ŒํŠธ์˜ ์ค‘๋ณต ์ œ๊ฑฐ

241~284ํ–‰์—์„œ Empty์™€ Error ์ƒํƒœ์— ๋Œ€ํ•œ UI ์ฝ”๋“œ๊ฐ€ ์ค‘๋ณต๋˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค. ๊ณตํ†ต๋œ ์ปดํฌ์ €๋ธ” ํ•จ์ˆ˜๋ฅผ ๋งŒ๋“ค์–ด ์ค‘๋ณต์„ ์ œ๊ฑฐํ•˜๊ณ  ์žฌ์‚ฌ์šฉ์„ฑ์„ ๋†’์ด๋Š” ๊ฒƒ์ด ์ข‹์Šต๋‹ˆ๋‹ค.

์˜ˆ๋ฅผ ๋“ค์–ด, ๋‹ค์Œ๊ณผ ๊ฐ™์ด ๊ณตํ†ต ์ปดํฌ๋„ŒํŠธ๋ฅผ ์ •์˜ํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค:

@Composable
fun ProgramListStateMessage(
    icon: @Composable () -> Unit,
    message: String
) {
    Column(
        verticalArrangement = Arrangement.spacedBy(28.dp, Alignment.CenterVertically),
        horizontalAlignment = Alignment.CenterHorizontally,
        modifier = Modifier
            .fillMaxSize()
            .verticalScroll(rememberScrollState())
            .background(color = colors.white)
    ) {
        icon()
        Text(
            text = message,
            style = typography.bodyRegular2,
            color = colors.gray400
        )
    }
}

๊ทธ๋ฆฌ๊ณ  ๊ฐ๊ฐ์˜ ์ƒํƒœ์—์„œ ์ด๋ฅผ ํ™œ์šฉํ•ฉ๋‹ˆ๋‹ค:

is StandardProgramListUiState.Empty -> {
    ProgramListStateMessage(
        icon = {
            ExpoIcon(
                tint = colors.black,
                modifier = Modifier.size(100.dp)
            )
        },
        message = "์•„์ง ์ผ๋ฐ˜ ํ”„๋กœ๊ทธ๋žจ์ด ๋“ฑ์žฅํ•˜์ง€ ์•Š์•˜์–ด์š”.."
    )
}

165-212: ๋ ˆ์ด์•„์›ƒ ๊ตฌ์„ฑ ๊ฐœ์„  ์ œ์•ˆ

165~212ํ–‰์—์„œ Spacer์™€ Modifier.width()๋ฅผ ์ด์šฉํ•˜์—ฌ ์š”์†Œ ๊ฐ„์˜ ๊ฐ„๊ฒฉ์„ ์กฐ์ •ํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค. ์ด๋Ÿฌํ•œ ๋ฐฉ์‹์€ ํ™”๋ฉด ํฌ๊ธฐ์— ๋”ฐ๋ผ ๋ ˆ์ด์•„์›ƒ์ด ๊นจ์งˆ ์ˆ˜ ์žˆ์œผ๋ฏ€๋กœ weight๋‚˜ Arrangement.spacedBy๋ฅผ ํ™œ์šฉํ•˜์—ฌ ์œ ์—ฐํ•œ ๋ ˆ์ด์•„์›ƒ์„ ๊ตฌ์„ฑํ•˜๋Š” ๊ฒƒ์ด ์ข‹์Šต๋‹ˆ๋‹ค.

์˜ˆ๋ฅผ ๋“ค์–ด, ๋‹ค์Œ๊ณผ ๊ฐ™์ด ์ˆ˜์ •ํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค:

Row(
    verticalAlignment = Alignment.CenterVertically,
    horizontalArrangement = Arrangement.spacedBy(16.dp)
) {
    Text(
        text = "ํ”„๋กœ๊ทธ๋žจ",
        style = typography.captionBold1,
        color = colors.gray600,
        modifier = Modifier.weight(1f)
    )
    Text(
        text = "์‹œ์ž‘์‹œ๊ฐ„",
        style = typography.captionBold1,
        color = colors.gray600,
        modifier = Modifier.weight(1f)
    )
    Text(
        text = "์ข…๋ฃŒ์‹œ๊ฐ„",
        style = typography.captionBold1,
        color = colors.gray600,
        modifier = Modifier.weight(1f)
    )
    Text(
        text = "์„ ํƒ",
        style = typography.captionBold1,
        color = colors.gray600,
        modifier = Modifier.weight(0.5f)
    )
    Text(
        text = "ํ•„์ˆ˜",
        style = typography.captionBold1,
        color = colors.gray600,
        modifier = Modifier.weight(0.5f)
    )
}

3-6: ๋ถˆํ•„์š”ํ•œ import ๋ฌธ ์ •๋ฆฌ

3~6ํ–‰์—์„œ ์ถ”๊ฐ€๋œ import ๋ฌธ ์ค‘ ์‚ฌ์šฉ๋˜์ง€ ์•Š๋Š” ๊ฒƒ์ด ์žˆ์Šต๋‹ˆ๋‹ค. ๋ถˆํ•„์š”ํ•œ import ๋ฌธ์„ ์ œ๊ฑฐํ•˜์—ฌ ์ฝ”๋“œ๋ฅผ ์ •๋ฆฌํ•˜๋Š” ๊ฒƒ์ด ์ข‹์Šต๋‹ˆ๋‹ค.

feature/home/src/main/java/com/school_of_company/home/view/component/ProgramList.kt (1)

72-83: ํ”„๋ฆฌ๋ทฐ ๋ฐ์ดํ„ฐ์˜ ํ˜„์‹ค์„ฑ ๊ฐœ์„  ํ•„์š”

ํ”„๋ฆฌ๋ทฐ ํ•จ์ˆ˜์˜ ํ…Œ์ŠคํŠธ ๋ฐ์ดํ„ฐ๊ฐ€ ๋„ˆ๋ฌด ๊ธฐ๋ณธ์ ์ž…๋‹ˆ๋‹ค. ์‹ค์ œ ์‚ฌ์šฉ ์‚ฌ๋ก€๋ฅผ ๋” ์ž˜ ๋ฐ˜์˜ํ•˜๋„๋ก ๊ฐœ์„ ์ด ํ•„์š”ํ•ฉ๋‹ˆ๋‹ค.

๋‹ค์Œ๊ณผ ๊ฐ™์ด ๋” ํ˜„์‹ค์ ์ธ ๋ฐ์ดํ„ฐ๋กœ ์ˆ˜์ •ํ•˜๋Š” ๊ฒƒ์„ ์ œ์•ˆํ•ฉ๋‹ˆ๋‹ค:

     ProgramList(
         trainingItem = persistentListOf(
             TrainingProgramListResponseEntity(
                 id = 0,
-                title = "title",
-                startedAt = "startedAt",
-                endedAt = "endedAt",
+                title = "2024๋…„ ์‹ ์ž… ๊ฐœ๋ฐœ์ž ํ•„์ˆ˜ ๊ต์œก",
+                startedAt = "2024-01-15T09:00:00",
+                endedAt = "2024-01-15T18:00:00",
                 category = "ESSENTIAL"
             )
         ),
         navigateToProgramDetail = {}
     )
feature/home/src/main/java/com/school_of_company/home/view/component/StandardProgramListItem.kt (1)

62-87: ํ™”๋ฉด ํฌ๊ธฐ์— ๋”ฐ๋ฅธ ๋ ˆ์ด์•„์›ƒ ๋Œ€์‘ ํ•„์š”

๊ณ ์ •๋œ ๋„ˆ๋น„ ๊ฐ’์„ ์‚ฌ์šฉํ•˜๋ฉด ์ž‘์€ ํ™”๋ฉด์—์„œ ๋ฌธ์ œ๊ฐ€ ๋ฐœ์ƒํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

๋‹ค์Œ๊ณผ ๊ฐ™์€ ๊ฐœ์„  ์‚ฌํ•ญ์„ ๊ณ ๋ คํ•ด๋ณด์„ธ์š”:

  1. ์ž‘์€ ํ™”๋ฉด์—์„œ๋„ ๋Œ€์‘ํ•  ์ˆ˜ ์žˆ๋„๋ก ๋™์  ๋„ˆ๋น„ ๊ณ„์‚ฐ ๋„์ž…
  2. ์ตœ์†Œ/์ตœ๋Œ€ ๋„ˆ๋น„ ์ œํ•œ ์„ค์ •
  3. ํ™”๋ฉด ํฌ๊ธฐ์— ๋”ฐ๋ฅธ ๋ฐ˜์‘ํ˜• ๋ ˆ์ด์•„์›ƒ ๊ตฌํ˜„
๐Ÿ“œ Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between af8a403 and 544a74e.

๐Ÿ“’ Files selected for processing (7)
  • feature/home/src/main/java/com/school_of_company/home/view/HomeDetailProgramParticipantScreen.kt (2 hunks)
  • feature/home/src/main/java/com/school_of_company/home/view/HomeDetailProgramScreen.kt (7 hunks)
  • feature/home/src/main/java/com/school_of_company/home/view/component/HomeDetailProgramParticipantListItem.kt (2 hunks)
  • feature/home/src/main/java/com/school_of_company/home/view/component/ProgramList.kt (1 hunks)
  • feature/home/src/main/java/com/school_of_company/home/view/component/ProgramListItem.kt (3 hunks)
  • feature/home/src/main/java/com/school_of_company/home/view/component/ProgramTabRowItem.kt (1 hunks)
  • feature/home/src/main/java/com/school_of_company/home/view/component/StandardProgramListItem.kt (2 hunks)
๐Ÿ”‡ Additional comments (5)
feature/home/src/main/java/com/school_of_company/home/view/component/ProgramTabRowItem.kt (1)

35-35: ์„ ํƒ๋œ ํƒญ์˜ ์ƒ‰์ƒ ๋ณ€๊ฒฝ์ด ์ ์ ˆํ•ด ๋ณด์ž…๋‹ˆ๋‹ค.

๋””์ž์ธ ์š”๊ตฌ์‚ฌํ•ญ์— ๋งž์ถฐ ์„ ํƒ๋œ ํƒญ์˜ ํ…์ŠคํŠธ ์ƒ‰์ƒ์„ ๋ฉ”์ธ ํ…Œ๋งˆ ์ƒ‰์ƒ์œผ๋กœ ๋ณ€๊ฒฝํ•œ ๊ฒƒ์ด ์ ์ ˆํ•ด ๋ณด์ž…๋‹ˆ๋‹ค. ์ด๋Š” ์‚ฌ์šฉ์ž๊ฐ€ ํ˜„์žฌ ์„ ํƒ๋œ ํƒญ์„ ๋” ์‰ฝ๊ฒŒ ์‹๋ณ„ํ•  ์ˆ˜ ์žˆ๋„๋ก ๋„์™€์ค„ ๊ฒƒ์ž…๋‹ˆ๋‹ค.

์ƒ‰์ƒ ๋Œ€๋น„๋ฅผ ํ™•์ธํ•˜๊ธฐ ์œ„ํ•ด ๋‹ค์Œ ์Šคํฌ๋ฆฝํŠธ๋ฅผ ์‹คํ–‰ํ•˜์„ธ์š”:

โœ… Verification successful

์ƒ‰์ƒ ๋Œ€๋น„๊ฐ€ ์ ์ ˆํ•˜๊ฒŒ ๊ตฌํ˜„๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

๋ฉ”์ธ ์ƒ‰์ƒ(#448FFF)๊ณผ ํšŒ์ƒ‰(#909090) ๋ชจ๋‘ ๋ฐฐ๊ฒฝ์ƒ‰๊ณผ ์ถฉ๋ถ„ํ•œ ๋Œ€๋น„๋ฅผ ๋ณด์—ฌ์ฃผ์–ด ์ ‘๊ทผ์„ฑ ๊ธฐ์ค€์„ ๋งŒ์กฑํ•ฉ๋‹ˆ๋‹ค. ์„ ํƒ๋œ ํƒญ์˜ ๋ฉ”์ธ ์ƒ‰์ƒ์ด ๋” ๋ˆˆ์— ๋„๋ฉฐ, ๋น„์„ ํƒ ์ƒํƒœ์˜ ํšŒ์ƒ‰๋„ ๊ฐ€๋…์„ฑ์„ ํ•ด์น˜์ง€ ์•Š๋Š” ์ ์ ˆํ•œ ํ†ค์ž…๋‹ˆ๋‹ค.

๐Ÿ Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: ๋ฉ”์ธ ์ƒ‰์ƒ๊ณผ ํšŒ์ƒ‰ ๊ณ„์—ด ์ƒ‰์ƒ์˜ ์ •์˜๋ฅผ ํ™•์ธํ•ฉ๋‹ˆ๋‹ค.

# colors ๊ฐ์ฒด์—์„œ main๊ณผ gray500 ์ƒ‰์ƒ ์ •์˜๋ฅผ ๊ฒ€์ƒ‰
rg -A 1 "main\s*=|gray500\s*=" --type kotlin

Length of output: 602

feature/home/src/main/java/com/school_of_company/home/view/component/HomeDetailProgramParticipantListItem.kt (1)

34-38: Row ์ปดํฌ๋„ŒํŠธ์˜ ๊ฐ„๊ฒฉ ์กฐ์ •์ด ์ ์ ˆํ•ด ๋ณด์ž…๋‹ˆ๋‹ค.

horizontalArrangement๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ํ•ญ๋ชฉ ๊ฐ„ 20.dp ๊ฐ„๊ฒฉ์„ ์ถ”๊ฐ€ํ•œ ๊ฒƒ์ด ๋””์ž์ธ ์š”๊ตฌ์‚ฌํ•ญ์— ๋งž๊ฒŒ ์ž˜ ๊ตฌํ˜„๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

feature/home/src/main/java/com/school_of_company/home/view/HomeDetailProgramParticipantScreen.kt (1)

190-194: ์ˆ˜ํ‰ ์Šคํฌ๋กค ๋ ˆ์ด์•„์›ƒ์˜ ๊ฐ„๊ฒฉ์ด ๊ฐœ์„ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

horizontalArrangement๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ํ•ญ๋ชฉ ๊ฐ„ ๊ฐ„๊ฒฉ์„ ์ผ๊ด€๋˜๊ฒŒ ์œ ์ง€ํ•˜๋„๋ก ์ˆ˜์ •๋œ ๊ฒƒ์ด ์ข‹์Šต๋‹ˆ๋‹ค. ๋‹ค๋งŒ, ์ ‘๊ทผ์„ฑ ์ธก๋ฉด์—์„œ ๊ณ ๋ คํ•ด๋ณผ ์‚ฌํ•ญ์ด ์žˆ์Šต๋‹ˆ๋‹ค.

์Šคํฌ๋กค ๊ฐ€๋Šฅํ•œ ์˜์—ญ์ด ์žˆ๋‹ค๋Š” ๊ฒƒ์„ ์‚ฌ์šฉ์ž์—๊ฒŒ ๋” ๋ช…ํ™•ํ•˜๊ฒŒ ์•Œ๋ฆฌ๊ธฐ ์œ„ํ•ด ๋‹ค์Œ ์‚ฌํ•ญ๋“ค์„ ํ™•์ธํ•ด์ฃผ์„ธ์š”:

feature/home/src/main/java/com/school_of_company/home/view/HomeDetailProgramScreen.kt (1)

298-340: Empty์™€ Error ์ƒํƒœ UI ์ปดํฌ๋„ŒํŠธ์˜ ์ค‘๋ณต ์ œ๊ฑฐ

298~340ํ–‰์—์„œ๋„ TrainingProgramListUiState์˜ Empty์™€ Error ์ƒํƒœ์— ๋Œ€ํ•œ ์ค‘๋ณต๋œ UI ์ฝ”๋“œ๊ฐ€ ๋‚˜ํƒ€๋‚ฉ๋‹ˆ๋‹ค. ์•ž์„œ ์ œ์•ˆํ•œ ๊ณตํ†ต ์ปดํฌ๋„ŒํŠธ๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ ์ค‘๋ณต์„ ์ œ๊ฑฐํ•˜๋ฉด ์ฝ”๋“œ์˜ ๊ฐ€๋…์„ฑ๊ณผ ์œ ์ง€๋ณด์ˆ˜์„ฑ์ด ํ–ฅ์ƒ๋ฉ๋‹ˆ๋‹ค.

feature/home/src/main/java/com/school_of_company/home/view/component/ProgramListItem.kt (1)

33-34: ์ˆ˜ํ‰ ์Šคํฌ๋กค ์ƒํƒœ ๊ณต์œ  ๊ฒ€ํ†  ํ•„์š”

์ˆ˜ํ‰ ์Šคํฌ๋กค ์ƒํƒœ๊ฐ€ ๊ฐ ์•„์ดํ…œ๋งˆ๋‹ค ๋…๋ฆฝ์ ์œผ๋กœ ๊ด€๋ฆฌ๋˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค. ์‚ฌ์šฉ์ž ๊ฒฝํ—˜ ํ–ฅ์ƒ์„ ์œ„ํ•ด ์Šคํฌ๋กค ์ƒํƒœ๋ฅผ ๊ณต์œ ํ•˜๋Š” ๊ฒƒ์ด ์ข‹์„ ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.

๋‹ค๋ฅธ ๋ฆฌ์ŠคํŠธ ์•„์ดํ…œ์—์„œ๋„ ๋™์ผํ•œ ํŒจํ„ด์ด ์‚ฌ์šฉ๋˜๋Š”์ง€ ํ™•์ธ์ด ํ•„์š”ํ•ฉ๋‹ˆ๋‹ค:

Also applies to: 46-46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0๏ธโƒฃ Priority: Critical ์šฐ์„ ์ˆœ์œ„ - ๊ธด๊ธ‰!!!!! โ™ป๏ธ Refactor ์ฝ”๋“œ ๋ฆฌํŒฉํ† ๋ง
Projects
None yet
2 participants