Add a mechanism to rename columns #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
what is the hold up here? |
|
Perhaps @SchrodingersGat doesn't really like my implementation. But you can always use: |
|
@set-soft sorry for the delay on this, it had completely fallen off my radar. If you can please fix the conflicts with |
|
@set-soft @SchrodingersGat , |
- **Pull-request**: [SchrodingersGat#82](SchrodingersGat#82) - **Opened**: 2020-03-18 - **Status**: Open - **Branch**: column_rename -## Description Column names displayed in the table head are the names of the KiCad fields or the internal names used by KiBoM. Sometimes the names aren't pretty. As an example is common to use `manf#` for the part name used by the component manufacturer. Using long names for KiCad fields is a bad idea. This patch allows to rename the columns names so you can use pretty names in the headings. You must define a `COLUMN_RENAME` section in the configuration file. Then add entries with the name of the original field and the name you want, separated by a tab (ASCII 9). Here is an example: ``` [COLUMN_RENAME] manf# Manufacturer part number ``` Note that you must use a tab as separator. Using a space won't work because *Manufacturer part number* also has spaces. -## Limitations The separator must be a tab. -## Additional notes - This patch also makes the `prefs.ignore` list lowercase. This is to avoid converting it to lower case all the time. - `prefs.colRename` is a hash. I saw that various preference options should also be a *dict* instead of a *list*.
- This code comes from SchrodingersGat#145 - I think is wrong, just fixing the flake8 error.
|
Hi @BillyPocketNC !
My fault, I didn't notice @SchrodingersGat asked for conflict resolution. |
|
Thanks :) |
|
Thanks this will be useful 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Column names displayed in the table head are the names of the KiCad fields or the internal names used by KiBoM.
Sometimes the names aren't pretty. As an example is common to use
manf#for the part name used by the component manufacturer.Using long names for KiCad fields is a bad idea.
This patch allows to rename the columns names so you can use pretty names in the headings.
You must define a
COLUMN_RENAMEsection in the configuration file.Then add entries with the name of the original field and the name you want, separated by a tab (ASCII 9).
Here is an example:
Note that you must use a tab as separator. Using a space won't work because Manufacturer part number also has spaces.
Limitations
The separator must be a tab.
Additional notes
prefs.ignorelist lowercase.This is to avoid converting it to lower case all the time.
prefs.colRenameis a hash. I saw that various preference options should also be a dict instead of a list.