Add flag to output variant name to BoM filename #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to `KiBOM_CLI.py`: - Add logic to include variant name in filename if flag is set. - Clean up some rogue whitespace. Changes to `README.md`: - Add description for new `includeVariantName` flag. - Add `include_variant_name` flag to default `bom.ini`. - Fix inconsistencies in capitalisation of "BoM". - Add missing `include_version_number` flag to default `bom.ini`. Changes to `bomlib/preferences.py`: - Add support for `include_variant_name`, `includeVariantName` where appropriate
|
This all seems quite reasonable. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @SchrodingersGat,
Just following up from yesterdays pull you did for #37 which added support for multiple variants. I had seen the value in adding these variants names to the BoM filename, and @AngusP (author of #37) had intended himself to add support for this. I believe this patch I have written satisfies this feature.
There is a certain amount of personal preference when it comes to how this variant name actually gets included in the filename so in particular I would advise that you review line 183 of
KiBOM_CLI.py(and therefore line 210 ofREADME.md).Cheers.
Changes made:
Changes to
KiBOM_CLI.py:Changes to
README.md:includeVariantNameflag.include_variant_nameflag to defaultbom.ini.include_version_numberflag to defaultbom.ini.Changes to
bomlib/preferences.py:include_variant_name,includeVariantNamewhereappropriate