Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): run migrations after postgres is up & running #66

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

TheJoin95
Copy link
Member

@TheJoin95 TheJoin95 commented Oct 7, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Adding a healthcheck which is going to be useful on a fresh install or slow docker-compose booting time.
As per now the migration container won't wait the Postgres service to be up & running so it won't be able to connect 100% of the docker-compose up commands (depending on the system) to the postgres service and this will turn out as a failed migration step.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@TheJoin95 TheJoin95 requested a review from LobeTia October 7, 2024 15:04
@TheJoin95
Copy link
Member Author

@LobeTia lint is failing but I believe it's going to get fixed with the draft PR #63 , am I right?

@LobeTia LobeTia merged commit d539559 into main Oct 8, 2024
1 check failed
@LobeTia LobeTia deleted the fix/docker-migrations branch October 8, 2024 11:32
@LobeTia
Copy link
Member

LobeTia commented Oct 8, 2024

@LobeTia lint is failing but I believe it's going to get fixed with the draft PR #63 , am I right?

Correct, will be fixed with #63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants