Chore and bugfix/fix thumbnail upload and update dependency versions #123
Conversation
This is a folder generated during build process of older version if this project. Currently, we don't build this project in any way and generally, build artifacts are not commited on git
…mage upload input
…version and fix breaking changes in code
|
@TheJoin95 Could you elaborate please? IF someone cloned the repo before this PR, then, normally, people sync their repos with latest changes from master before making changes in the code, right? |
| async function clickXpath(page, xpath, options = {}) { | ||
| await page.waitForXPath(xpath, options); | ||
| const [elementHandle] = await page.$x(xpath); | ||
| await clickDom(page, elementHandle); | ||
| } |
There was a problem hiding this comment.
I'm sorry to have not been clear: I was referring to this function being removed.
So people who used the function previously, they won't be able to do it anymore.
Anyway, I'm ok to drop the use of this function
There was a problem hiding this comment.
Ah yes, you are right, but normally, if someone wants to make a PR, or sync with latest changes from our master, they would need to apply the change in their code that they maintain for themselves. Good to note in release notes anyway, it would benefit the maintainers of private forks for example.
Wabri
deleted the
chore_and_bugfix/fixThumbnailUploadAndUpdateDependencyVersions
branch
Here I list the coomits made by this PR to better understand what was done:
This is a folder generated during build process of older version if this project. Currently, we don't build this project in any way and generally, build artifacts are not commited on git