Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shapes_text.md #103

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update shapes_text.md #103

wants to merge 1 commit into from

Conversation

zachcuy
Copy link
Member

@zachcuy zachcuy commented Nov 4, 2021

Still needs a picture but don't have right now because I'm on a different pc without the spark library installed.

@@ -606,3 +606,33 @@ def draw():
Results in:

![text_size() example](img/text_size.png)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a title

Suggested change
#### Drawing Lines

```python
%%ignite

def setup():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use consistent spacing in the example (i.e. 4 spaces per tab)


Example(s):

```python
Copy link
Member

@AlphaRLee AlphaRLee Nov 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add line highlight

Suggested change
```python
```python hl_lines="6"


Results in:

[NEEDS PICTURE]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update this to point to the right spot. Also rename your PNG from draw-line to draw_line for consistency

Suggested change
[NEEDS PICTURE]
![draw_line() example](docs/draw_line.png)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants