Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license in Template #12

Merged
merged 5 commits into from
Oct 29, 2021
Merged

Add license in Template #12

merged 5 commits into from
Oct 29, 2021

Conversation

linuxluigi
Copy link
Collaborator

Add LICENSE & CODEOWNERS files in template.

But I'm not sure what to do, if there should no OpenSource license will be selected. Add in post hook to delete the LICENSE file or let it be empty?

_template/LICENSE Outdated Show resolved Hide resolved
options.yml Outdated Show resolved Hide resolved
options.yml Outdated Show resolved Hide resolved
options.yml Outdated Show resolved Hide resolved
@brumhard
Copy link
Contributor

Also please remember to rebase as soon as #11 is merged.

@patrick246
Copy link
Member

My suggestion would be to add a "Copyright {{ .CurrentYear }} by {{ .CopyrightOwner }}" in the LICENSE file if no license has been selected

Steffen Exler added 2 commits October 29, 2021 10:58
Signed-off-by: Steffen Exler <Steffen.Exler@mail.schwarz>
Signed-off-by: Steffen Exler <Steffen.Exler@mail.schwarz>
Signed-off-by: Tobias Brumhard <tobias.brumhard@mail.schwarz>
Signed-off-by: Tobias Brumhard <tobias.brumhard@mail.schwarz>
Signed-off-by: Tobias Brumhard <tobias.brumhard@mail.schwarz>
Copy link
Contributor

@brumhard brumhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 👍🏻

@linuxluigi linuxluigi merged commit d34553f into main Oct 29, 2021
@linuxluigi linuxluigi deleted the feature/add-license-option branch October 29, 2021 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants