-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add license in Template #12
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brumhard
suggested changes
Sep 30, 2021
Also please remember to rebase as soon as #11 is merged. |
linuxluigi
force-pushed
the
feature/add-license-option
branch
from
October 15, 2021 09:47
c6ec446
to
6d72919
Compare
My suggestion would be to add a "Copyright {{ .CurrentYear }} by {{ .CopyrightOwner }}" in the LICENSE file if no license has been selected |
Signed-off-by: Steffen Exler <Steffen.Exler@mail.schwarz>
linuxluigi
force-pushed
the
feature/add-license-option
branch
from
October 29, 2021 08:58
6d72919
to
c781024
Compare
Signed-off-by: Tobias Brumhard <tobias.brumhard@mail.schwarz>
Signed-off-by: Tobias Brumhard <tobias.brumhard@mail.schwarz>
Signed-off-by: Tobias Brumhard <tobias.brumhard@mail.schwarz>
brumhard
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
LICENSE
&CODEOWNERS
files in template.But I'm not sure what to do, if there should no OpenSource license will be selected. Add in post hook to delete the
LICENSE
file or let it be empty?