feat(OnyxNavItem): Implement OnyxNavItem #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7a13014 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
BoppLi
previously requested changes
Jun 21, 2024
packages/sit-onyx/src/components/OnyxNavItem/future/OnyxNavItem.vue
Outdated
Show resolved
Hide resolved
packages/sit-onyx/src/components/OnyxNavItem/future/OnyxNavItem.vue
Outdated
Show resolved
Hide resolved
larsrickert
previously requested changes
Jun 21, 2024
packages/sit-onyx/src/components/OnyxNavButton/OnyxNavButton.stories.ts
Outdated
Show resolved
Hide resolved
larsrickert
reviewed
Jun 21, 2024
packages/sit-onyx/src/components/OnyxNavItem/future/OnyxNavItem.vue
Outdated
Show resolved
Hide resolved
JoCa96
reviewed
Jun 26, 2024
JoCa96
reviewed
Jun 26, 2024
packages/headless/src/composables/menuButton/createMenuButton.ts
Outdated
Show resolved
Hide resolved
JoCa96
reviewed
Jun 26, 2024
packages/headless/src/composables/menuButton/createMenuButton.ts
Outdated
Show resolved
Hide resolved
JoCa96
reviewed
Jun 26, 2024
packages/headless/src/composables/menuButton/createMenuButton.ts
Outdated
Show resolved
Hide resolved
JoCa96
reviewed
Jun 26, 2024
JoCa96
reviewed
Jun 26, 2024
JoCa96
reviewed
Jun 26, 2024
packages/sit-onyx/src/components/OnyxNavItem/future/OnyxNavItem.vue
Outdated
Show resolved
Hide resolved
larsrickert
requested changes
Jun 27, 2024
larsrickert
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #883
Implemented new OnyxNavItem component which is similar to OnyxListItem, but will be used in OnyxNavButton only.
Checklist
npx changeset addif your changes should be released as npm package (because they affect the library usage)