feat(icons): implement changeset generation #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
larsrickert
force-pushed
the
feat/939-icon-import-changeset
branch
2 times, most recently
from
8d676d6
to
c55a620
Compare
This is an auto-generated pull request. All Figma icons have been updated. Co-authored-by: larsrickert <67898185+larsrickert@users.noreply.github.com>
larsrickert
force-pushed
the
feat/939-icon-import-changeset
branch
from
3b80835
to
b2b3635
Compare
JoCa96
previously approved these changes
Aug 26, 2024
MajaZarkova
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #939
Generate changeset with list of new, deleted and modified icons whenever we import icons from Figma so they are released as npm package.
I also removed UX from codeowners for the icons so they are not added as required reviewer. The UX review process will be done in Figma so we devs should be responsible to approve the technical import via CI to make sure everything is imported correctly.