Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix updated at timestamps #1810

Merged
merged 7 commits into from
Aug 29, 2024
Merged

Conversation

larsrickert
Copy link
Collaborator

@larsrickert larsrickert commented Aug 29, 2024

relates to #1615

VitePress shows timestamps at the bottom of every page when it was last updated.
image

Previously when building the onyx docs, all pages had the same timestamp (build time) which was caused by a build error because of the createOnyx() Vue plugin which did not fully support server side rendering.

You can test this PR by running:

  1. cd apps/docs
  2. pnpm build
  3. pnpm preview

Checklist

  • The added / edited code has been documented with JSDoc
  • A changeset is added with npx changeset add if your changes should be released as npm package (because they affect the library usage)

@larsrickert larsrickert requested a review from a team as a code owner August 29, 2024 07:44
Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: 2d49bdf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
sit-onyx Major
@sit-onyx/nuxt Major
demo-app Patch
playground Patch
@sit-onyx/chartjs-plugin Major
@sit-onyx/storybook-utils Major
@sit-onyx/vitepress-theme Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@larsrickert larsrickert changed the title docs: fix timestamps docs: fix updated at timestamps Aug 29, 2024
@larsrickert larsrickert enabled auto-merge (squash) August 29, 2024 12:58
@larsrickert larsrickert merged commit dfa58b8 into main Aug 29, 2024
19 checks passed
@larsrickert larsrickert deleted the fix/1615-vitepress-timestamp branch August 29, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants