perf: improve Storybook performance #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 207a353 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoCa96
previously approved these changes
Sep 11, 2024
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: larsrickert <67898185+larsrickert@users.noreply.github.com>
This is an auto-generated pull request. All Playwright screenshots have been updated. Co-authored-by: larsrickert <67898185+larsrickert@users.noreply.github.com>
JoCa96
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Storybook to version 8.3.0-alpha.5 which includes a bug fix which reduced the bundle size of our build Storybook from 26MB to 6MB and reduced build time from 37s to 10s.
This change also significantly improves the loading performance of the onyx Storybook.
If you are interested, the bug was caused by the vue-component-meta package which included ALL schema definitions for props, events, slots and exposed so if e.g. HTMLElement was used, it included all nested props, JSDocs etc. although they are not needed/used by Storybook, see Storybook PR
Checklist
npx changeset addif your changes should be released as npm package (because they affect the library usage)