Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add relevant events logging #1880

Merged
merged 15 commits into from
Sep 18, 2024
Merged

Conversation

JoCa96
Copy link
Contributor

@JoCa96 JoCa96 commented Sep 17, 2024

A new Storybook Util withNativeEventLoggingFor is introduced.
It generates Storybook ArgTypes that allow us to document and log relevant native events in Storybook.
These can be merged with other ArgTypes.
The native events will be documented in a new section "Relevant HTML Events".

Relates to #1603

@JoCa96 JoCa96 requested a review from a team as a code owner September 17, 2024 14:38
Copy link

changeset-bot bot commented Sep 17, 2024

🦋 Changeset detected

Latest commit: eb7cab3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sit-onyx/storybook-utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@JoCa96 JoCa96 changed the title add relevant events logging chore: add relevant events logging Sep 17, 2024
.changeset/tender-zebras-flow.md Show resolved Hide resolved
packages/storybook-utils/src/actions.ts Outdated Show resolved Hide resolved
packages/storybook-utils/src/actions.ts Outdated Show resolved Hide resolved
packages/storybook-utils/src/actions.ts Outdated Show resolved Hide resolved
@larsrickert larsrickert self-assigned this Sep 17, 2024
@JoCa96 JoCa96 enabled auto-merge (squash) September 18, 2024 09:26
Copy link
Collaborator

@larsrickert larsrickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

packages/storybook-utils/src/events.ts Outdated Show resolved Hide resolved
packages/storybook-utils/src/events.ts Show resolved Hide resolved
JoCa96 and others added 2 commits September 18, 2024 11:54
Co-authored-by: Lars Rickert <lars.rickert@mail.schwarz>
This is an auto-generated pull request. All Playwright screenshots have
been updated.

Co-authored-by: JoCa96 <18483883+JoCa96@users.noreply.github.com>
@JoCa96 JoCa96 merged commit 889383b into main Sep 18, 2024
19 checks passed
@JoCa96 JoCa96 deleted the joca96/feat-1603-add-native-logging branch September 18, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants