Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(OnyxFormElement): Implement success messages to OnyxFormElement #2050

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

MajaZarkova
Copy link
Contributor

@MajaZarkova MajaZarkova commented Nov 6, 2024

Relates to #573

Implement success messages to OnyxFormElement and success state of OnyxInput

@MajaZarkova MajaZarkova requested a review from a team as a code owner November 6, 2024 11:27
Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: f571f3b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@JoCa96 JoCa96 self-assigned this Nov 7, 2024
Comment on lines 29 to 31
* Configures if success state is shown.
* When `true`, success state will be shown.
* When `false`, success state will never be shown.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unsure if we want the success state to be shown for all form elements at once.
I would like to ask @jannick-ux if that is a use-case we want to support, or if it only should be used sporadically.

Suggested change
* Configures if success state is shown.
* When `true`, success state will be shown.
* When `false`, success state will never be shown.
* Toggle success state for all form elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants