Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add better check for logout urls #820

Merged
merged 2 commits into from
Oct 18, 2023
Merged

feat: add better check for logout urls #820

merged 2 commits into from
Oct 18, 2023

Conversation

martin-trajanovski
Copy link
Collaborator

Description

Improve the resolution of the logout_url by checking for end_session endpoint.

Junjiequan
Junjiequan approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@Junjiequan Junjiequan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small comment, otherwise looks good to me

src/auth/auth.service.ts Outdated Show resolved Hide resolved
@martin-trajanovski martin-trajanovski merged commit 8f62192 into master Oct 18, 2023
7 checks passed
@martin-trajanovski martin-trajanovski deleted the add-better-check-for-logout-urls branch October 18, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Junjiequan Junjiequan Junjiequan approved these changes

@nitrosx nitrosx Awaiting requested review from nitrosx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-trajanovski @Junjiequan