Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improved elastic search query filter #837

Merged
merged 13 commits into from
Nov 1, 2023
Merged

fix: improved elastic search query filter #837

merged 13 commits into from
Nov 1, 2023

Conversation

Junjiequan
Copy link
Contributor

@Junjiequan Junjiequan commented Oct 25, 2023 •
edited
Loading

Description

This PR contains following fixes and improves:

Fixes:

  • Fixed ScientificMetadata condition filter. Before the change, filter does not work with floating number, due to incorrect mapping settings for elastic search.

Improves:

  • Included fallback for elastic search. Before the change, the datasets table is empty if ES DB is not synched with mongoDB. Now, the dataset full query endpoint checks if ES query returns any result, if ES query does not return result then it uses regular mongo query.

Motivation

Background on use case, changes needed

Fixes:

  • Items added

Changes:

  • changes made

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?

@Junjiequan Junjiequan marked this pull request as draft October 25, 2023 11:49
@Junjiequan Junjiequan marked this pull request as ready for review October 27, 2023 10:12
bpedersen2
bpedersen2 requested changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@bpedersen2 bpedersen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for some minor comments, looks fine.

@Junjiequan
Copy link
Contributor Author

@bpedersen2 Could you copy paste the comments here? I'm not able to see the comments somehow

dependabot bot and others added 4 commits October 31, 2023 10:09
@dependabot
build(deps): bump actions/setup-node from 3 to 4
ffe0da0 
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@github-actions
Merge pull request #855 from SciCatProject/dependabot/github_actions/…
69b7562 
…actions/setup-node-4

build(deps): bump actions/setup-node from 3 to 4
@Junjiequan
fix: fixed pagination conflict between ES and mongo query
102c942
@Junjiequan
fix: remove empty space in string value of condition filter with trim()
3f3e488
bpedersen2
bpedersen2 reviewed Oct 31, 2023
View reviewed changes
src/elastic-search/configuration/indexSetting.ts
@@ -39,12 +39,12 @@ export const dynamic_template:
path_match: "scientificMetadata.*.*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

long_as_double??

@bpedersen2
Copy link
Contributor

needs local rebase and force-pushing to SWAP-3608-scicat-datasets-table-total-number-and-actual-i branch

@Junjiequan Junjiequan changed the base branch from master to release-4-5a November 1, 2023 09:12
@Junjiequan Junjiequan merged commit b267738 into release-4-5a Nov 1, 2023
8 checks passed
@Junjiequan Junjiequan deleted the SWAP-3608-scicat-datasets-table-total-number-and-actual-i branch November 1, 2023 09:17
Junjiequan added a commit that referenced this pull request Nov 1, 2023
@Junjiequan @dependabot @github-actions
fix: improved elastic search query filter (#837)
f1aaced 
* fix: improved elastic search query filter

* fix: updated mathJS package version && improved number check

* fix: fixed inconsistency between data list and count number

* fix: minor naming change

* fix: improved mapping for digit with floating points

* fix: revert back to mongo query if es db doesnt return any value

* build(deps): bump actions/setup-node from 3 to 4

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix: fixed pagination conflict between ES and mongo query

* fix: remove empty space in string value of condition filter with trim()

* fix: minor change for object name and removed redundant type

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@Junjiequan Junjiequan restored the SWAP-3608-scicat-datasets-table-total-number-and-actual-i branch November 1, 2023 10:22
Junjiequan added a commit that referenced this pull request Nov 1, 2023
@Junjiequan
Revert "fix: improved elastic search query filter (#837)"
0aca683 
This reverts commit b267738.
@Junjiequan Junjiequan mentioned this pull request Nov 1, 2023
Closed
@Junjiequan Junjiequan mentioned this pull request Nov 1, 2023
Merged
Junjiequan added a commit that referenced this pull request Nov 1, 2023
@Junjiequan
fix: improved elastic search query filter #837 (#861)
ec60892 
* fix: improved elastic search query filter

* fix: updated mathJS package version && improved number check

* fix: fixed inconsistency between data list and count number

* fix: minor naming change

* fix: improved mapping for digit with floating points

* fix: revert back to mongo query if es db doesnt return any value

* fix: fixed pagination conflict between ES and mongo query

* fix: remove empty space in string value of condition filter with trim()

* fix: minor change for object name and removed redundant type
@Junjiequan Junjiequan deleted the SWAP-3608-scicat-datasets-table-total-number-and-actual-i branch November 1, 2023 10:46
Junjiequan added a commit that referenced this pull request Nov 7, 2023
@Junjiequan @dependabot @github-actions
Add: added elastic search aggregation to query facet objects (#859)
c76c6f7 
* fix: improved elastic search query filter

* fix: updated mathJS package version && improved number check

* fix: fixed inconsistency between data list and count number

* fix: minor naming change

* fix: improved mapping for digit with floating points

* fix: revert back to mongo query if es db doesnt return any value

* fix: fixed pagination conflict between ES and mongo query

* fix: remove empty space in string value of condition filter with trim()

* fix: minor change for object name and removed redundant type

* fix: improved elastic search query filter (#837)

* fix: improved elastic search query filter

* fix: updated mathJS package version && improved number check

* fix: fixed inconsistency between data list and count number

* fix: minor naming change

* fix: improved mapping for digit with floating points

* fix: revert back to mongo query if es db doesnt return any value

* build(deps): bump actions/setup-node from 3 to 4

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix: fixed pagination conflict between ES and mongo query

* fix: remove empty space in string value of condition filter with trim()

* fix: minor change for object name and removed redundant type

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* build(deps-dev): bump @types/express-session from 1.17.8 to 1.17.9

Bumps [@types/express-session](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express-session) from 1.17.8 to 1.17.9.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express-session)

---
updated-dependencies:
- dependency-name: "@types/express-session"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps-dev): bump @nestjs/cli from 10.2.0 to 10.2.1

Bumps [@nestjs/cli](https://github.com/nestjs/nest-cli) from 10.2.0 to 10.2.1.
- [Release notes](https://github.com/nestjs/nest-cli/releases)
- [Changelog](https://github.com/nestjs/nest-cli/blob/master/.release-it.json)
- [Commits](nestjs/nest-cli@10.2.0...10.2.1)

---
updated-dependencies:
- dependency-name: "@nestjs/cli"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump @elastic/elasticsearch from 8.9.0 to 8.10.0

Bumps [@elastic/elasticsearch](https://github.com/elastic/elasticsearch-js) from 8.9.0 to 8.10.0.
- [Release notes](https://github.com/elastic/elasticsearch-js/releases)
- [Changelog](https://github.com/elastic/elasticsearch-js/blob/main/docs/changelog.asciidoc)
- [Commits](elastic/elasticsearch-js@v8.9.0...v8.10.0)

---
updated-dependencies:
- dependency-name: "@elastic/elasticsearch"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps-dev): bump concurrently from 8.2.1 to 8.2.2

Bumps [concurrently](https://github.com/open-cli-tools/concurrently) from 8.2.1 to 8.2.2.
- [Release notes](https://github.com/open-cli-tools/concurrently/releases)
- [Commits](open-cli-tools/concurrently@v8.2.1...v8.2.2)

---
updated-dependencies:
- dependency-name: concurrently
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps-dev): bump @types/node-fetch from 2.6.6 to 2.6.7

Bumps [@types/node-fetch](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node-fetch) from 2.6.6 to 2.6.7.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node-fetch)

---
updated-dependencies:
- dependency-name: "@types/node-fetch"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump @nestjs/axios from 3.0.0 to 3.0.1

Bumps [@nestjs/axios](https://github.com/nestjs/axios) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/nestjs/axios/releases)
- [Changelog](https://github.com/nestjs/axios/blob/master/.release-it.json)
- [Commits](nestjs/axios@3.0.0...3.0.1)

---
updated-dependencies:
- dependency-name: "@nestjs/axios"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps-dev): bump @types/luxon from 3.3.2 to 3.3.3

Bumps [@types/luxon](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/luxon) from 3.3.2 to 3.3.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/luxon)

---
updated-dependencies:
- dependency-name: "@types/luxon"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps-dev): bump @types/mocha from 10.0.2 to 10.0.3

Bumps [@types/mocha](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mocha) from 10.0.2 to 10.0.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mocha)

---
updated-dependencies:
- dependency-name: "@types/mocha"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps-dev): bump @types/passport-local from 1.0.36 to 1.0.37

Bumps [@types/passport-local](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/passport-local) from 1.0.36 to 1.0.37.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/passport-local)

---
updated-dependencies:
- dependency-name: "@types/passport-local"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump mathjs from 11.11.2 to 12.0.0

Bumps [mathjs](https://github.com/josdejong/mathjs) from 11.11.2 to 12.0.0.
- [Changelog](https://github.com/josdejong/mathjs/blob/develop/HISTORY.md)
- [Commits](josdejong/mathjs@v11.11.2...v12.0.0)

---
updated-dependencies:
- dependency-name: mathjs
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps-dev): bump sinon from 16.1.0 to 17.0.0

Bumps [sinon](https://github.com/sinonjs/sinon) from 16.1.0 to 17.0.0.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md)
- [Commits](sinonjs/sinon@v16.1.0...v17.0.0)

---
updated-dependencies:
- dependency-name: sinon
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix: improved elastic search query filter (#837)

* fix: improved elastic search query filter

* fix: updated mathJS package version && improved number check

* fix: fixed inconsistency between data list and count number

* fix: minor naming change

* fix: improved mapping for digit with floating points

* fix: revert back to mongo query if es db doesnt return any value

* build(deps): bump actions/setup-node from 3 to 4

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix: fixed pagination conflict between ES and mongo query

* fix: remove empty space in string value of condition filter with trim()

* fix: minor change for object name and removed redundant type

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix: included ES aggregation for fullfacet

* fix: removed esEnabled flag from createFullFacetPipeline function

* fix: minor clean up

* fix: minor cleanup

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Junjiequan added a commit that referenced this pull request Nov 13, 2023
@Junjiequan
fix: improved elastic search query filter #837 (#861)
c1b9f9b 
* fix: improved elastic search query filter

* fix: updated mathJS package version && improved number check

* fix: fixed inconsistency between data list and count number

* fix: minor naming change

* fix: improved mapping for digit with floating points

* fix: revert back to mongo query if es db doesnt return any value

* fix: fixed pagination conflict between ES and mongo query

* fix: remove empty space in string value of condition filter with trim()

* fix: minor change for object name and removed redundant type
Junjiequan added a commit that referenced this pull request Nov 13, 2023
@Junjiequan @dependabot @github-actions
Add: added elastic search aggregation to query facet objects (#859)
bba67be 
* fix: improved elastic search query filter

* fix: updated mathJS package version && improved number check

* fix: fixed inconsistency between data list and count number

* fix: minor naming change

* fix: improved mapping for digit with floating points

* fix: revert back to mongo query if es db doesnt return any value

* fix: fixed pagination conflict between ES and mongo query

* fix: remove empty space in string value of condition filter with trim()

* fix: minor change for object name and removed redundant type

* fix: improved elastic search query filter (#837)

* fix: improved elastic search query filter

* fix: updated mathJS package version && improved number check

* fix: fixed inconsistency between data list and count number

* fix: minor naming change

* fix: improved mapping for digit with floating points

* fix: revert back to mongo query if es db doesnt return any value

* build(deps): bump actions/setup-node from 3 to 4

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix: fixed pagination conflict between ES and mongo query

* fix: remove empty space in string value of condition filter with trim()

* fix: minor change for object name and removed redundant type

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* build(deps-dev): bump @types/express-session from 1.17.8 to 1.17.9

Bumps [@types/express-session](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express-session) from 1.17.8 to 1.17.9.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express-session)

---
updated-dependencies:
- dependency-name: "@types/express-session"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps-dev): bump @nestjs/cli from 10.2.0 to 10.2.1

Bumps [@nestjs/cli](https://github.com/nestjs/nest-cli) from 10.2.0 to 10.2.1.
- [Release notes](https://github.com/nestjs/nest-cli/releases)
- [Changelog](https://github.com/nestjs/nest-cli/blob/master/.release-it.json)
- [Commits](nestjs/nest-cli@10.2.0...10.2.1)

---
updated-dependencies:
- dependency-name: "@nestjs/cli"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump @elastic/elasticsearch from 8.9.0 to 8.10.0

Bumps [@elastic/elasticsearch](https://github.com/elastic/elasticsearch-js) from 8.9.0 to 8.10.0.
- [Release notes](https://github.com/elastic/elasticsearch-js/releases)
- [Changelog](https://github.com/elastic/elasticsearch-js/blob/main/docs/changelog.asciidoc)
- [Commits](elastic/elasticsearch-js@v8.9.0...v8.10.0)

---
updated-dependencies:
- dependency-name: "@elastic/elasticsearch"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps-dev): bump concurrently from 8.2.1 to 8.2.2

Bumps [concurrently](https://github.com/open-cli-tools/concurrently) from 8.2.1 to 8.2.2.
- [Release notes](https://github.com/open-cli-tools/concurrently/releases)
- [Commits](open-cli-tools/concurrently@v8.2.1...v8.2.2)

---
updated-dependencies:
- dependency-name: concurrently
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps-dev): bump @types/node-fetch from 2.6.6 to 2.6.7

Bumps [@types/node-fetch](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node-fetch) from 2.6.6 to 2.6.7.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node-fetch)

---
updated-dependencies:
- dependency-name: "@types/node-fetch"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump @nestjs/axios from 3.0.0 to 3.0.1

Bumps [@nestjs/axios](https://github.com/nestjs/axios) from 3.0.0 to 3.0.1.
- [Release notes](https://github.com/nestjs/axios/releases)
- [Changelog](https://github.com/nestjs/axios/blob/master/.release-it.json)
- [Commits](nestjs/axios@3.0.0...3.0.1)

---
updated-dependencies:
- dependency-name: "@nestjs/axios"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps-dev): bump @types/luxon from 3.3.2 to 3.3.3

Bumps [@types/luxon](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/luxon) from 3.3.2 to 3.3.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/luxon)

---
updated-dependencies:
- dependency-name: "@types/luxon"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps-dev): bump @types/mocha from 10.0.2 to 10.0.3

Bumps [@types/mocha](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/mocha) from 10.0.2 to 10.0.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/mocha)

---
updated-dependencies:
- dependency-name: "@types/mocha"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps-dev): bump @types/passport-local from 1.0.36 to 1.0.37

Bumps [@types/passport-local](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/passport-local) from 1.0.36 to 1.0.37.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/passport-local)

---
updated-dependencies:
- dependency-name: "@types/passport-local"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps): bump mathjs from 11.11.2 to 12.0.0

Bumps [mathjs](https://github.com/josdejong/mathjs) from 11.11.2 to 12.0.0.
- [Changelog](https://github.com/josdejong/mathjs/blob/develop/HISTORY.md)
- [Commits](josdejong/mathjs@v11.11.2...v12.0.0)

---
updated-dependencies:
- dependency-name: mathjs
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* build(deps-dev): bump sinon from 16.1.0 to 17.0.0

Bumps [sinon](https://github.com/sinonjs/sinon) from 16.1.0 to 17.0.0.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/main/docs/changelog.md)
- [Commits](sinonjs/sinon@v16.1.0...v17.0.0)

---
updated-dependencies:
- dependency-name: sinon
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix: improved elastic search query filter (#837)

* fix: improved elastic search query filter

* fix: updated mathJS package version && improved number check

* fix: fixed inconsistency between data list and count number

* fix: minor naming change

* fix: improved mapping for digit with floating points

* fix: revert back to mongo query if es db doesnt return any value

* build(deps): bump actions/setup-node from 3 to 4

Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3 to 4.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* fix: fixed pagination conflict between ES and mongo query

* fix: remove empty space in string value of condition filter with trim()

* fix: minor change for object name and removed redundant type

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix: included ES aggregation for fullfacet

* fix: removed esEnabled flag from createFullFacetPipeline function

* fix: minor clean up

* fix: minor cleanup

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpedersen2 bpedersen2 bpedersen2 approved these changes

@nitrosx nitrosx Awaiting requested review from nitrosx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Junjiequan @bpedersen2