-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add some extra tests for creating datasets including pid with right access groups #910
Merged
nitrosx
merged 9 commits into
master
from
SWAP-3611-add-dataset-creation-with-pid-tests
Nov 28, 2023
Merged
test: add some extra tests for creating datasets including pid with right access groups #910
nitrosx
merged 9 commits into
master
from
SWAP-3611-add-dataset-creation-with-pid-tests
Nov 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-trajanovski
changed the title
test: add some extra tests for creating datasets with right access gr…
test: add some extra tests for creating datasets with right access groups
Nov 23, 2023
martin-trajanovski
changed the title
test: add some extra tests for creating datasets with right access groups
test: add some extra tests for creating datasets including pid with right access groups
Nov 23, 2023
…://github.com/SciCatProject/scicat-backend-next into SWAP-3611-add-dataset-creation-with-pid-tests
Junjiequan
requested changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's room for test accuracy improvement with small changes, looks good otherwise
…://github.com/SciCatProject/scicat-backend-next into SWAP-3611-add-dataset-creation-with-pid-tests
Junjiequan
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
nitrosx
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add the missing API tests for dataset authorization.
ADMIN GROUPS:
CREATE_DATASET_GROUPS:
CREATE_DATASET_WITH_PID_GROUPS:
CREATE_DATASET_PRIVILEGED_GROUPS:
Motivation
Tests for different dataset creation groups were missing.
Fixes:
Changes:
Tests included/Docs Updated?