Features toggles #153
Merged
Features toggles #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minottic
force-pushed
the
features_toggles
branch
from
bd20139 to
00d19f5
Compare
minottic
force-pushed
the
features_toggles
branch
from
00d19f5 to
2ee8887
Compare
|
I also think that going forward we might want to reorganise the services a little. Basically I would have 1 single backend folder and inside v3 and v4 and inside each the services specific to them (e.g. elastic inside v4) |
minottic
force-pushed
the
features_toggles
branch
3 times, most recently
from
1b54e35 to
a57ab2c
Compare
fpotier
approved these changes
May 24, 2024
minottic
force-pushed
the
features_toggles
branch
from
a57ab2c to
bd1a874
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@consolethinks @fpotier this is how I would see enabling/disabling features (for now jobs (rabbitmq) and elastic).
I prefer this over profiles as it's explained in the main readme. Just look at 1st and 2nd commit if you are interested in seeing what happens.
After #152 is merged, I will rebase and make it ready for review