Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change empty override files to symlinks #196

Merged
merged 2 commits into from
Jun 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ To add a new service (see the [backend v4](./services/backend/services/v4/) for
2. name it as the service
3. create the `compose.yaml` file with the required dependencies (if any)
4. eventually, include any service in (2) and (3) which is specific to the service and not shared across the global setup
5. eventually, add additional configurable logic (e.g. [BE_VERSION dependency](./services/frontend/compose.yaml#L14) and [ELASTIC_ENABLED dependency](./services/backend/services/v4/compose.yaml)). Remember to add an empty `.compose.<FEATURE>.yaml` (e.g. [here](./services/backend/services/v4/.compose.elastic.yaml)) if the service supports on/off. This also include DEV configurations, e.g. [here](./services/searchapi/compose.dev.yaml)
5. eventually, add additional configurable logic (e.g. [BE_VERSION dependency](./services/frontend/compose.yaml#L14) and [ELASTIC_ENABLED dependency](./services/backend/services/v4/compose.yaml)). Remember to add a `.compose.<FEATURE>.yaml` symlink to [.empty.yaml](./services/.empty.yaml) (e.g. [here](./services/backend/services/v4/.compose.elastic.yaml)) if the service supports on/off. This also includes DEV configurations, e.g. [here](./services/searchapi/compose.dev.yaml)
6. eventually, add entrypoints for init logics, as described [here](#if-the-service-does-not-support-entrypoints-yet-one-needs-to)
7. eventually, add the platform field, as described [here](#supported-os-architectures)
8. eventually, create a `config` folder if it requires configuration
Expand Down
1 change: 1 addition & 0 deletions services/.empty.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
## empty file used when override configs are not enabled
1 change: 0 additions & 1 deletion services/backend/.compose.dev.yaml

This file was deleted.

1 change: 1 addition & 0 deletions services/backend/.compose.dev.yaml
1 change: 0 additions & 1 deletion services/backend/.compose.ldap.yaml

This file was deleted.

1 change: 1 addition & 0 deletions services/backend/.compose.ldap.yaml
1 change: 0 additions & 1 deletion services/backend/.compose.oidc.yaml

This file was deleted.

1 change: 1 addition & 0 deletions services/backend/.compose.oidc.yaml
1 change: 0 additions & 1 deletion services/backend/services/v3/.compose.dev.yaml

This file was deleted.

1 change: 1 addition & 0 deletions services/backend/services/v3/.compose.dev.yaml
1 change: 0 additions & 1 deletion services/backend/services/v3/.compose.jobs.yaml

This file was deleted.

1 change: 1 addition & 0 deletions services/backend/services/v3/.compose.jobs.yaml

This file was deleted.

1 change: 0 additions & 1 deletion services/backend/services/v4/.compose.dev.yaml

This file was deleted.

1 change: 1 addition & 0 deletions services/backend/services/v4/.compose.dev.yaml
1 change: 0 additions & 1 deletion services/backend/services/v4/.compose.elastic.yaml

This file was deleted.

1 change: 1 addition & 0 deletions services/backend/services/v4/.compose.elastic.yaml
1 change: 0 additions & 1 deletion services/frontend/.compose.dev.yaml

This file was deleted.

1 change: 1 addition & 0 deletions services/frontend/.compose.dev.yaml
1 change: 0 additions & 1 deletion services/searchapi/.compose.dev.yaml

This file was deleted.

1 change: 1 addition & 0 deletions services/searchapi/.compose.dev.yaml