Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add landing page service #325

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Add landing page service #325

merged 3 commits into from
Oct 2, 2024

Conversation

minottic
Copy link
Contributor

@minottic minottic commented Oct 2, 2024

This PR adds the landing page SciCat service. It is split into commits for readability:

  1. Adds the landingpage service, with its minimal configuration and its README + the main README required changes + the service inclusion in the main compose.yaml file
  2. Adds the ability to the service added in (1) to use be and fe URLs whenever the user sets BACKEND_HTTPS_URL and FRONTEND_HTTPS_URL. This is required as the landingpage, being a SPA, cannot use the docker internal network and uses the host network from the browser. It also includes README required changes
  3. Adds the ability to create the landingpage environment with DEV=true mode. It includes the required changes in the README

closes: #29

@minottic minottic force-pushed the lp branch 2 times, most recently from 74aea6c to c9e77c4 Compare October 2, 2024 12:55
Add config

Add README

Add documentation to main README

Add landingpage to main compose.yaml includes
Update README with HTTPS changes

Use newer image and fix config
Add DEV instructions to landingpage README

Use newer image and fix config
@minottic minottic merged commit a275873 into main Oct 2, 2024
9 checks passed
@minottic minottic deleted the lp branch October 2, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SciCat LandingPage container
3 participants