-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
646 use graph model with ABMs v3 #1085
base: main
Are you sure you want to change the base?
Conversation
…/SciCompMod/memilio into 646-use-graph-model-with-abms-v2
…/SciCompMod/memilio into 646-use-graph-model-with-abms-v2
…/SciCompMod/memilio into 646-use-graph-model-with-abms-v2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are only a small things left to improve and one discussion item.
cpp/models/abm/person.h
Outdated
@@ -438,7 +430,6 @@ class Person | |||
.add("rnd_go_to_school_hour", m_random_goto_school_hour) | |||
.add("mask", m_mask) | |||
.add("compliance", m_compliance) | |||
.add("index", m_person_index) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might have to add the new data members to this list.
cpp/models/abm/person.h
Outdated
GlobalID | ||
m_global_id; ///< Unique identifier of a person. Is only relevant in graph abm, otherwise is equal to m_person_index. | ||
PersonId m_person_id; ///< Unique identifier of a person. | ||
uint32_t m_rng_index; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. Well now instead of the person index we have the rng index.
In all current use cases, we could use the other constructor of PersonalRNG that uses the index directly from its index in the world. However, when we want to construct the PersonalRNG inside the Person or anywhere where the world is not known, this is a problem.
Further, this rng_index needs to be updated each time a person is removed and added to a world, such that it uses the correct world index and doesn't clash with the same rng_index of another person.
Let's discuss in the next meeting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Only one point left to discuss from my side.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)