-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1185 wrong index in ode seir model #1186
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1186 +/- ##
=======================================
Coverage 96.97% 96.97%
=======================================
Files 148 148
Lines 13718 13718
=======================================
Hits 13303 13303
Misses 415 415 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for findings this typo. Just one short comment. Then we can merge this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. One last comment :) Then we can merge this PR
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
model.h
of ODE SEIR modeltest_odeseir.cpp
that would have failed with the previous wrong indexIf need be, add additional information and what the reviewer should look out for in particular:
Closes #1185 .
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)