-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1195 Formatter for date to have consistent Format #1198
1195 Formatter for date to have consistent Format #1198
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1198 +/- ##
==========================================
+ Coverage 97.12% 97.21% +0.09%
==========================================
Files 148 154 +6
Lines 13782 14203 +421
==========================================
+ Hits 13386 13808 +422
+ Misses 396 395 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice addition, makes the logging of dates a lot easier. Good tests too.
The changes requested are only small details.
In models/ide_secir/parameters_io.h:292-298 there are two more dates only used for a log_warning, could you replace them as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All change requests are addressed (and comments further improved). Code cov fails due to missed lines, which
- were also not covered prior to this PR,
- and consist of logging related code, which we intentionally do not test in most cases.
Changes and Information
Please briefly list the changes (main added features, changed items, or corrected bugs) made:
If need be, add additional information and what the reviewer should look out for in particular:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)