Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1195 Formatter for date to have consistent Format #1198

Merged
merged 9 commits into from
Feb 17, 2025

Conversation

HenrZu
Copy link
Contributor

@HenrZu HenrZu commented Jan 21, 2025

Changes and Information

Please briefly list the changes (main added features, changed items, or corrected bugs) made:

  • print date object per default in iso format using spdlog

If need be, add additional information and what the reviewer should look out for in particular:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful (with and without OpenMP)
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added
  • (For ABM development) Checked benchmark results and ran and posted a local test above from before and after development to ensure performance is monitored.

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes, code coverage and performance is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • On merge, add 2-5 lines with the changes (main added features, changed items, or corrected bugs) to the merge-commit-message. This can be taken from the briefly-list-the-changes above (best case) or the separate commit messages (worst case).

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.21%. Comparing base (1df315d) to head (1b7d250).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
cpp/models/ode_secirts/parameters_io.h 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1198      +/-   ##
==========================================
+ Coverage   97.12%   97.21%   +0.09%     
==========================================
  Files         148      154       +6     
  Lines       13782    14203     +421     
==========================================
+ Hits        13386    13808     +422     
+ Misses        396      395       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HenrZu HenrZu linked an issue Jan 22, 2025 that may be closed by this pull request
2 tasks
@HenrZu HenrZu changed the title print and output date in iso format 1195 Formatter for date to have consistent Format Jan 22, 2025
@HenrZu HenrZu requested a review from reneSchm January 29, 2025 11:08
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice addition, makes the logging of dates a lot easier. Good tests too.

The changes requested are only small details.

In models/ide_secir/parameters_io.h:292-298 there are two more dates only used for a log_warning, could you replace them as well?

cpp/memilio/utils/date.h Outdated Show resolved Hide resolved
cpp/memilio/utils/date.h Outdated Show resolved Hide resolved
cpp/memilio/utils/date.h Outdated Show resolved Hide resolved
cpp/memilio/utils/date.h Outdated Show resolved Hide resolved
@HenrZu HenrZu requested a review from reneSchm February 14, 2025 12:35
Copy link
Member

@reneSchm reneSchm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All change requests are addressed (and comments further improved). Code cov fails due to missed lines, which

  • were also not covered prior to this PR,
  • and consist of logging related code, which we intentionally do not test in most cases.

@HenrZu HenrZu merged commit 040d985 into main Feb 17, 2025
57 of 58 checks passed
@HenrZu HenrZu deleted the 1195-Formatter-for-date-to-have-consistent-Format branch February 17, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatter for date to have consistent Format
2 participants