-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
511 Compute inflow and outflow of models #574
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m:DLR-SC/memilio into 511--Compute-inflow-and-outflow-of-models
…flow-and-outflow-of-models
…m:DLR-SC/memilio into 511--Compute-inflow-and-outflow-of-models
…m:DLR-SC/memilio into 511--Compute-inflow-and-outflow-of-models
…m:DLR-SC/memilio into 511--Compute-inflow-and-outflow-of-models
dabele
requested changes
Nov 9, 2023
Co-authored-by: dabele <daniel.abele@dlr.de>
make MultiIndexIterator more compatible with the STL
mknaranja
approved these changes
Nov 14, 2023
dabele
approved these changes
Nov 14, 2023
Thank you @dabele and @mknaranja for reviewing 🥳 |
mknaranja
added a commit
that referenced
this pull request
Nov 14, 2023
- Compute and Integrate Flows between the Compartments of the ODE model - Backwards compatibility with old design (see FlowModel::get_derivatives) - New FlowModel extending the existing Compartmentalmodel - New FlowSimulation extending current Simulation which also calculates flows - Converted all ODE models (except ode_sir) to use the FlowModel/FlowSimulation - Adding Plot table feature for the time series - Some Performance/Design gains for the Integrator/Simulation - Removed TotalInfections compartment. This can now easily be computed using the flows - Added a TypeList with metaprogramming utilities: - type_at_index - index_of_type - is_type_in_list - Added function extend_index and reduce_index - And some benchmarks ... :) Co-authored-by: reneSchm <49305466+reneSchm@users.noreply.github.com> Co-authored-by: Martin J. Kühn <62713180+mknaranja@users.noreply.github.com> Co-authored-by: dabele <daniel.abele@dlr.de>
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
The following questions are addressed in the documentation if need be:
Developers (what did you do?, how can it be maintained?)
For users (how to use your work?)
For admins (how to install and configure your work?)
For documentation: Please write or update the Readme in the current working directory!
Checks by code reviewer(s):
closes #511
closes #317