-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
750 add file based io to cli #751
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
==========================================
+ Coverage 94.20% 94.82% +0.61%
==========================================
Files 108 110 +2
Lines 8510 8616 +106
==========================================
+ Hits 8017 8170 +153
+ Misses 493 446 -47
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good. Only some small comments :)
Co-authored-by: Henrik Zunker <69154294+HenrZu@users.noreply.github.com>
…lio into 750-add-file-based-io-to-cli
Changes and Information
Please briefly list the changes made, additional Information and what the Reviewer should look out for:
Please check if the naming and description of built-in options is good (you may use the example, i.e.
cli_example --help
).Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #750