Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

750 add file based io to cli #751

Merged
merged 8 commits into from
Oct 19, 2023
Merged

750 add file based io to cli #751

merged 8 commits into from
Oct 19, 2023

Conversation

reneSchm
Copy link
Member

@reneSchm reneSchm commented Aug 24, 2023

Changes and Information

Please briefly list the changes made, additional Information and what the Reviewer should look out for:

  • Added command line options and functions to read or write parameters from or to a file.

Please check if the naming and description of built-in options is good (you may use the example, i.e. cli_example --help).

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes and code coverage is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

Closes #750

@reneSchm reneSchm requested a review from xsaschako August 24, 2023 09:52
@reneSchm reneSchm self-assigned this Aug 24, 2023
@reneSchm reneSchm linked an issue Aug 24, 2023 that may be closed by this pull request
2 tasks
@reneSchm reneSchm added loc::backend This issue concerns the C++ backend implementation. class::improvement Cleanup that doesn't affect functionality labels Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (84a3d3b) 94.20% compared to head (e5e0052) 94.82%.
Report is 23 commits behind head on main.

❗ Current head e5e0052 differs from pull request most recent head 7d97200. Consider uploading reports for the commit 7d97200 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #751      +/-   ##
==========================================
+ Coverage   94.20%   94.82%   +0.61%     
==========================================
  Files         108      110       +2     
  Lines        8510     8616     +106     
==========================================
+ Hits         8017     8170     +153     
+ Misses        493      446      -47     
Files Coverage Δ
cpp/memilio/io/cli.h 100.00% <100.00%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reneSchm reneSchm requested review from HenrZu and removed request for xsaschako August 28, 2023 07:44
Copy link
Contributor

@HenrZu HenrZu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Only some small comments :)

cpp/memilio/io/README.md Outdated Show resolved Hide resolved
cpp/memilio/io/cli.h Outdated Show resolved Hide resolved
cpp/memilio/io/cli.h Outdated Show resolved Hide resolved
cpp/memilio/io/cli.h Outdated Show resolved Hide resolved
cpp/tests/test_io_cli.cpp Show resolved Hide resolved
cpp/tests/test_io_cli.cpp Outdated Show resolved Hide resolved
cpp/tests/test_io_cli.cpp Show resolved Hide resolved
cpp/tests/test_io_cli.cpp Outdated Show resolved Hide resolved
cpp/tests/test_io_cli.cpp Show resolved Hide resolved
reneSchm and others added 3 commits September 18, 2023 13:11
Co-authored-by: Henrik Zunker <69154294+HenrZu@users.noreply.github.com>
Co-authored-by: Henrik Zunker <69154294+HenrZu@users.noreply.github.com>
@reneSchm reneSchm requested a review from HenrZu September 25, 2023 15:02
cpp/memilio/io/README.md Outdated Show resolved Hide resolved
@HenrZu HenrZu merged commit 0ab43d3 into main Oct 19, 2023
19 checks passed
@HenrZu HenrZu deleted the 750-add-file-based-io-to-cli branch October 19, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add file based I/O to CLI
2 participants