-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
537 silence gmock warnings #801
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #801 +/- ##
==========================================
+ Coverage 94.98% 95.01% +0.02%
==========================================
Files 112 112
Lines 8776 8800 +24
==========================================
+ Hits 8336 8361 +25
+ Misses 440 439 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicemock makes sense here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicemock makes sense here,although this leads to a function not being called in timeseries. This currently needs to be fixed for a merge
I added a basic test for the PrintTo function. I wouldn't want the test to in any way restrict what the output should be like or be difficult to maintain, so it basically just tests that the function exists and does something. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense and looks good, thank you.
Changes and Information
Silence some gmock warnings in a unit test by using NiceMock. The default implementation for
get_result
of the Mock class does the right thing, so silencing the warning is OK.Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Close #537