Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

773 FutureWarnings in pycode #824

Merged
merged 7 commits into from
Nov 27, 2023
Merged

773 FutureWarnings in pycode #824

merged 7 commits into from
Nov 27, 2023

Conversation

patricklnz
Copy link
Member

@patricklnz patricklnz commented Nov 8, 2023

Changes and Information

Please briefly list the changes made, additional Information and what the Reviewer should look out for:

Merge Request - Guideline Checklist

Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.

Checks by code author

  • Every addressed issue is linked (use the "Closes #ISSUE" keyword below)
  • New code adheres to coding guidelines
  • No large data files have been added (files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)
  • Tests are added for new functionality and a local test run was successful
  • Appropriate documentation for new functionality has been added (Doxygen in the code and Markdown files if necessary)
  • Proper attention to licenses, especially no new third-party software with conflicting license has been added

Checks by code reviewer(s)

  • Corresponding issue(s) is/are linked and addressed
  • Code is clean of development artifacts (no deactivated or commented code lines, no debugging printouts, etc.)
  • Appropriate unit tests have been added, CI passes and code coverage is acceptable (did not decrease)
  • No large data files added in the whole history of commits(files should in sum not exceed 100 KB, avoid PDFs, Word docs, etc.)

Closes #773

@patricklnz patricklnz self-assigned this Nov 8, 2023
@patricklnz patricklnz requested a review from xsaschako November 8, 2023 10:53
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e375aa5) 95.25% compared to head (a659b08) 95.40%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
+ Coverage   95.25%   95.40%   +0.14%     
==========================================
  Files         113      117       +4     
  Lines        9103     9224     +121     
==========================================
+ Hits         8671     8800     +129     
+ Misses        432      424       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@xsaschako xsaschako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing each thing seperately, in contrast to just ignore the warnings.
But sadly even then I get a few future warnings. Even more with now pandas 2.1.2.
You tell me if this is okay, or we really should just turn them off.

@patricklnz patricklnz requested a review from xsaschako November 20, 2023 09:27
Copy link
Member

@xsaschako xsaschako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you

@xsaschako xsaschako merged commit e2e5dc7 into main Nov 27, 2023
64 checks passed
@xsaschako xsaschako deleted the 773-handle-futurewarnings branch November 27, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FutureWarnings in pycode with newly released pandas 2.1.1
2 participants