-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
773 FutureWarnings in pycode #824
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #824 +/- ##
==========================================
+ Coverage 95.25% 95.40% +0.14%
==========================================
Files 113 117 +4
Lines 9103 9224 +121
==========================================
+ Hits 8671 8800 +129
+ Misses 432 424 -8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing each thing seperately, in contrast to just ignore the warnings.
But sadly even then I get a few future warnings. Even more with now pandas 2.1.2.
You tell me if this is okay, or we really should just turn them off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you
Changes and Information
Please briefly list the changes made, additional Information and what the Reviewer should look out for:
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #773