Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Make FastDEQs fast again #45

Merged
merged 76 commits into from
Jun 6, 2022
Merged

[WIP] Make FastDEQs fast again #45

merged 76 commits into from
Jun 6, 2022

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Apr 9, 2022

Main Changes:

  • Moves from Flux to Lux -- Mainly to do away with the weird destructure/restructure and the several issues that come with it
  • Drop dependencies on unreleased branches (still requires some upstream merges but after this PR we can finally register the package)
  • Termination and Time-Stepping Tolerances have separate arguments

TODOs

  • Work on the Discrete Solvers
  • Jacobian Stabilization is completely broken
  • Update docs

Fixes #37

Requires LuxDL/Lux.jl#7 & avik-pal/FluxMPI.jl#15

@avik-pal avik-pal mentioned this pull request Apr 9, 2022
@avik-pal
Copy link
Member Author

avik-pal commented Apr 10, 2022

Note that the models used Tsit5 before and VCABM3 now which contributes to a minor improvement.

Original Numbers

  • CIFAR10: 6 processes across 2 V100s -- 450s per epoch

Some numbers after this partial rewrite:

  • CIFAR10: 1 process 1 V100 -- 320s per epoch
  • CIFAR10: 2 processes 2 V100s -- 250s per epoch
  • CIFAR10: 4 processes 4 V100s -- 120s per epoch

I might have messed up memory usage though, 4 processes on 2 GPUs error out sometimes 😢

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@b32e1b4). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 57a7abb differs from pull request most recent head 7e42c90. Consider uploading reports for the commit 7e42c90 to get more accurate results

@@           Coverage Diff           @@
##             main      #45   +/-   ##
=======================================
  Coverage        ?   85.71%           
=======================================
  Files           ?       14           
  Lines           ?      448           
  Branches        ?        0           
=======================================
  Hits            ?      384           
  Misses          ?       64           
  Partials        ?        0           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ChrisRackauckas ChrisRackauckas mentioned this pull request Jun 5, 2022
@avik-pal avik-pal merged commit 7e42c90 into main Jun 6, 2022
@avik-pal avik-pal deleted the ap/efl branch April 17, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different ODE Solvers
3 participants