ci: standardise workflows using SciML's reusable workflows #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Standardize the tests workflow, using the reusab SciML tests workflow. * Rename the tests workflow to `Tests.yml`, instead of `CI.yml`, since it's more semantically correct and CI encompasses all the workflows that are run.
thazhemadam
requested review from
devmotion and
ChrisRackauckas
and removed request for
devmotion
devmotion
reviewed
Apr 23, 2024
Since we don't test with Julia 1.6 anyways, remove the exclude block. Note: this was initially left in while the workflow was standardised to maintain status quo (with the previous version of the workflow).
devmotion
approved these changes
Apr 23, 2024
Comment on lines
+31
to
+33
| arch: x64 | ||
| coverage: true | ||
| uses: "SciML/.github/.github/workflows/tests.yml@v1" |
There was a problem hiding this comment.
It's not missing a - here?
There was a problem hiding this comment.
No, this syntax is correct, as evidenced by the workflows running as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the workflows in this repository to use SciML's reusable workflows.
This is part of a larger effort to standardise the SciML's CI workflows for more generic and common requirements, to keep the workflows uniform and easier to maintain.