Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dualT4 should not be promoted with T since T might already be a dual #958

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+6 −6
Open

dualT4 should not be promoted with T since T might already be a dual #958

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e9a5bc7
dualT4 should not be promoted with T since T might already be a dual
oscardssmith Nov 3, 2023
5134ffe
comment and remove 4th method
oscardssmith Nov 6, 2023
88c7527
typo
oscardssmith Nov 6, 2023
124bbb6
better fix
oscardssmith Nov 8, 2023
5473ea3
simplify
oscardssmith Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/norecompile.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,14 @@
dualT = dualgen(T)
dualT1 = ArrayInterface.promote_eltype(T1, dualT)
dualT2 = ArrayInterface.promote_eltype(T2, dualT)
dualT4 = dualgen(promote_type(T, T4))
dualT4 = promote_dual(dualgen(T4), dualT)

Check warning on line 60 in src/norecompile.jl

View check run for this annotation

Codecov / codecov/patch

src/norecompile.jl#L60 

Added line #L60 was not covered by tests

iip_arglists = (Tuple{T1, T2, T3, T4},
Tuple{dualT1, dualT2, T3, T4},
Tuple{dualT1, T2, T3, dualT4},
Tuple{dualT1, dualT2, T3, dualT4})
iip_arglists = (Tuple{T1, T2, T3, T4}, # primal

Check warning on line 62 in src/norecompile.jl

View check run for this annotation

Codecov / codecov/patch

src/norecompile.jl#L62 

Added line #L62 was not covered by tests
Tuple{dualT1, dualT2, T3, T4}, # vjp
Tuple{dualT1, T2, T3, dualT4}, # tgrad
)

iip_returnlists = ntuple(x -> Nothing, 4)
iip_returnlists = ntuple(x -> Nothing, length(iip_arglists))

Check warning on line 67 in src/norecompile.jl

View check run for this annotation

Codecov / codecov/patch

src/norecompile.jl#L67 

Added line #L67 was not covered by tests

fwt = map(iip_arglists, iip_returnlists) do A, R
FunctionWrappersWrappers.FunctionWrappers.FunctionWrapper{R, A}(Void(ff))
Expand Down
Loading