Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

DiffEqOperator Interface Compatibility #24

Closed
ChrisRackauckas opened this issue Jul 31, 2017 · 2 comments
Closed

DiffEqOperator Interface Compatibility #24

ChrisRackauckas opened this issue Jul 31, 2017 · 2 comments

Comments

@ChrisRackauckas
Copy link
Member

It'll be important to match the interface for it all to work in the stiff solvers "automatically". Here's a few points:

The problem is with update_coefficients!(A,t,u) which is different here.

https://github.com/JuliaDiffEq/DiffEqBase.jl/blob/master/src/diffeq_operator.jl#L6

The ODE solver needs to be able to call that an have the ODE update its coefficients. But also

https://github.com/JuliaDiffEq/PDEOperators.jl/blob/8ddcb5368824919ed46608f4ad2117b268e78b25/src/linear_operator.jl#L399

the call doesn't update the coefficients. I think that somehow there needs to be a system for if <: Number then BC is constant, otherwise assume the user gives a function a = bc(t) where a is the value for the constant you want.

@shivin9
Copy link
Contributor

shivin9 commented Aug 1, 2017

Yeah that was the system before, I was using anonymous functions with constant BC being represented as
t->constant. But then we decided that we should let the user update the values as he might do so in all sorts or different ways.

@ChrisRackauckas
Copy link
Member Author

I think I made a big mistake when I suggested that be changed. That's my bad.

xtalax added a commit to grahamas/DiffEqOperators.jl that referenced this issue May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants