This repository has been archived by the owner on Jul 19, 2023. It is now read-only.
New upwind operators #159
Merged
New upwind operators #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-> Small fix -> Passing tests. Some broke -> Corrected order 2 stencil -> Corrected Interior convolution for BoundaryPaddedArray -> [WIP]: Making bc_coeff_compositions tests pass
|
@ajozefiak Can you see why the 2D_3D tests are failing? Is it due to #145? |
shivin9
force-pushed
the
New_Upwind_Operators
branch
from
0b13a1a to
b11988c
Compare
| coeff = A.coefficients | ||
|
|
||
| # Upwind operators have a non-centred stencil | ||
| if use_winding(A) |
There was a problem hiding this comment.
no need for use_winding if dispatching to true?
There was a problem hiding this comment.
Yeah... I am making a followup PR for this.
|
|
||
| ################################################################################# | ||
|
|
||
| function convolve_interior_add_range!(x_temp::AbstractVector{T}, x::AbstractVector{T}, A::DerivativeOperator, offset::Int) where {T<:Real, N} |
|
Let's do some cleanup in a followup PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.