Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update for new AlgorithmInterpretation #1048

Merged
merged 4 commits into from
Sep 2, 2024
Merged

update for new AlgorithmInterpretation #1048

merged 4 commits into from
Sep 2, 2024

Conversation

prbzrg
Copy link
Member

@prbzrg prbzrg commented Sep 1, 2024

@ChrisRackauckas
Copy link
Member

This is going to need to bump the minor on SciMLBase and StochasticDiffEq, but other than that looks good to go.

@ChrisRackauckas
Copy link
Member

@oscardssmith did you never update the DiffEq tests with the default change?

@oscardssmith
Copy link
Contributor

oscardssmith commented Sep 2, 2024 •
edited
Loading

Oh, I guess I never did. Will fix.

Is the fix just deleting the tests since they now exist at the OrdinaryDiffEq level?

@prbzrg
Copy link
Member Author

prbzrg commented Sep 2, 2024

Is there any reason to keep codes related to ODE?

https://github.com/SciML/DifferentialEquations.jl/blob/master/src/ode_default_alg.jl

https://github.com/SciML/DifferentialEquations.jl/blob/master/test/default_ode_alg_test.jl

@oscardssmith
Copy link
Contributor

I don't think so.

@ChrisRackauckas
Copy link
Member

Are the same tests in OrdinaryDiffEq? If so then yes let's just delete.

@ChrisRackauckas
Copy link
Member

Rebase this and tests should pass.

@prbzrg prbzrg closed this Sep 2, 2024
@prbzrg prbzrg reopened this Sep 2, 2024
@ChrisRackauckas
Copy link
Member

@ErikQQY looks like some depwarns crept back in? https://github.com/SciML/DifferentialEquations.jl/actions/runs/10668385943/job/29567982165?pr=1048#step:6:584

We can merge this though.

@ChrisRackauckas ChrisRackauckas merged commit fdafa9c into SciML:master Sep 2, 2024
4 of 6 checks passed
@prbzrg prbzrg deleted the new-AlgorithmInterpretation branch September 2, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisRackauckas ChrisRackauckas ChrisRackauckas left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prbzrg @ChrisRackauckas @oscardssmith