Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move spatial tutorial from SciMLTutorials #277

Merged
merged 3 commits into from
Dec 10, 2022
Merged

Move spatial tutorial from SciMLTutorials #277

merged 3 commits into from
Dec 10, 2022

Conversation

ChrisRackauckas
Copy link
Member

Now that we have package docs for all of the packages and doctests, it makes sense for the tutorials to be built as part of the testing process. It also keeps everything organized by package. Thus SciMLTutorials is getting cannibalized into separate package docs, and this is the one for JumpProcesses. I did a few updates (DiffEqJump, LightGraphs, links) so hopefully this is enough. I might need a little bit of help getting this one completed though, since there are a few I need to tend to.

 Now that we have package docs for all of the packages and doctests, it makes sense for the tutorials to be built as part of the testing process. It also keeps everything organized by package. Thus SciMLTutorials is getting cannibalized into separate package docs, and this is the one for JumpProcesses. I did a few updates (DiffEqJump, LightGraphs, links) so hopefully this is enough. I might need a little bit of help getting this one completed though, since there are a few I need to tend to.
@ChrisRackauckas
Copy link
Member Author

@Vilin97 @isaacsas

@isaacsas
Copy link
Member

I can finish this one off.

@ChrisRackauckas
Copy link
Member Author

Thanks, I'll just close the tab then and move onto the next!

@coveralls
Copy link

coveralls commented Dec 10, 2022

Pull Request Test Coverage Report for Build 3664935807

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.4%) to 88.741%

Files with Coverage Reduction New Missed Lines %
src/aggregators/prioritytable.jl 1 86.86%
src/extended_jump_array.jl 1 27.54%
src/jumps.jl 1 87.28%
src/coupling.jl 2 78.18%
src/spatial/spatial_massaction_jump.jl 3 85.45%
Totals Coverage Status
Change from base Build 3544760886: 0.4%
Covered Lines: 1939
Relevant Lines: 2185

💛 - Coveralls

ChrisRackauckas added a commit to SciML/SciMLTutorials.jl that referenced this pull request Dec 10, 2022
Now that all of the packages have docs with tests, and we have a whole lot more testing hardware than we ever had before, we are starting to slim down the tutorials (which only get rebuilt and fixed periodically) and moving them to the individual package docs. We are doing this and turning all of the docs into downstream tests (SciML/SciMLDocs#104) so that they are perpetually working. It will be a massive amount of compute, but we have that now, so let's make everything super robust.

Related PRs:

- SciML/JumpProcesses.jl#277
- SciML/DiffEqParamEstim.jl#188
- SciML/DiffEqBayes.jl#274
@ChrisRackauckas
Copy link
Member Author

Looks like this just worked. Okay!

@ChrisRackauckas ChrisRackauckas merged commit f923fad into master Dec 10, 2022
@ChrisRackauckas ChrisRackauckas deleted the spatial branch December 10, 2022 16:50
@isaacsas
Copy link
Member

The tutorial needs some updates, but I can followup with those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants