-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move spatial tutorial from SciMLTutorials #277
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we have package docs for all of the packages and doctests, it makes sense for the tutorials to be built as part of the testing process. It also keeps everything organized by package. Thus SciMLTutorials is getting cannibalized into separate package docs, and this is the one for JumpProcesses. I did a few updates (DiffEqJump, LightGraphs, links) so hopefully this is enough. I might need a little bit of help getting this one completed though, since there are a few I need to tend to.
I can finish this one off. |
Thanks, I'll just close the tab then and move onto the next! |
Pull Request Test Coverage Report for Build 3664935807Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
ChrisRackauckas
added a commit
to SciML/SciMLTutorials.jl
that referenced
this pull request
Dec 10, 2022
Now that all of the packages have docs with tests, and we have a whole lot more testing hardware than we ever had before, we are starting to slim down the tutorials (which only get rebuilt and fixed periodically) and moving them to the individual package docs. We are doing this and turning all of the docs into downstream tests (SciML/SciMLDocs#104) so that they are perpetually working. It will be a massive amount of compute, but we have that now, so let's make everything super robust. Related PRs: - SciML/JumpProcesses.jl#277 - SciML/DiffEqParamEstim.jl#188 - SciML/DiffEqBayes.jl#274
Looks like this just worked. Okay! |
The tutorial needs some updates, but I can followup with those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have package docs for all of the packages and doctests, it makes sense for the tutorials to be built as part of the testing process. It also keeps everything organized by package. Thus SciMLTutorials is getting cannibalized into separate package docs, and this is the one for JumpProcesses. I did a few updates (DiffEqJump, LightGraphs, links) so hopefully this is enough. I might need a little bit of help getting this one completed though, since there are a few I need to tend to.