-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a return type wrapper #39
Conversation
Codecov Report
@@ Coverage Diff @@
## main JuliaLang/julia#39 +/- ##
==========================================
+ Coverage 85.31% 85.35% +0.04%
==========================================
Files 6 6
Lines 320 321 +1
==========================================
+ Hits 273 274 +1
Misses 47 47
Continue to review full report at Codecov.
|
@vpuri3 do you know why this would make v1.6 fail? 😅 |
so the in place solution is not the same as the one that is emitted by julia> VERSION
v"1.6.4"
julia> using LinearAlgebra
julia> n=8; A=rand(n,n); u=rand(n); b=A*u; v=zero(u); F=svd(A); ldiv!(v,F,b) ≈ u, v ≈ u
(true, false) julia> using LinearAlgebra
julia> VERSION
v"1.7.0"
julia> n=8; A=rand(n,n); u=rand(n); b=A*u; v=zero(u); F=svd(A); ldiv!(v,F,b) ≈ u, v ≈ u
(true, true) |
is this expected behavior or should this be an issue in LinearAlgebra? |
It looks like it was a bug that was fixed in v1.7 but should probably be backported to LTS. |
ok created an issue in julialang JuliaLang/LinearAlgebra.jl#895 |
No description provided.