Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a return type wrapper #39

Merged
merged 3 commits into from
Dec 12, 2021
Merged

Add a return type wrapper #39

merged 3 commits into from
Dec 12, 2021

Conversation

ChrisRackauckas
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 11, 2021

Codecov Report

Merging #39 (c30a203) into main (d7b478b) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      JuliaLang/julia#39      +/-   ##
==========================================
+ Coverage   85.31%   85.35%   +0.04%     
==========================================
  Files           6        6              
  Lines         320      321       +1     
==========================================
+ Hits          273      274       +1     
  Misses         47       47              
Impacted Files Coverage Δ
src/common.jl 72.50% <100.00%> (ø)
src/factorization.jl 94.44% <100.00%> (+0.10%) ⬆️
src/pardiso.jl 83.33% <100.00%> (ø)
src/wrappers.jl 91.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7b478b...c30a203. Read the comment docs.

@ChrisRackauckas
Copy link
Member Author

@vpuri3 do you know why this would make v1.6 fail? 😅

@vpuri3
Copy link
Member

vpuri3 commented Dec 11, 2021

Screenshot_20211211-212634
it's svd ! i would see if the factorization algorithm overwrites the matrix A which would cause the test A*u \approx b to not be appropriate

@vpuri3
Copy link
Member

vpuri3 commented Dec 12, 2021

so the in place solution is not the same as the one that is emitted by ldiv!(y fact, b) --> y in 1.6.4

julia> VERSION
v"1.6.4"

julia> using LinearAlgebra

julia> n=8; A=rand(n,n); u=rand(n); b=A*u; v=zero(u); F=svd(A); ldiv!(v,F,b)  u, v  u
(true, false)
julia> using LinearAlgebra

julia> VERSION
v"1.7.0"

julia> n=8; A=rand(n,n); u=rand(n); b=A*u; v=zero(u); F=svd(A); ldiv!(v,F,b)  u, v  u
(true, true)

@vpuri3
Copy link
Member

vpuri3 commented Dec 12, 2021

is this expected behavior or should this be an issue in LinearAlgebra?

@ChrisRackauckas ChrisRackauckas merged commit 9e225c4 into main Dec 12, 2021
@ChrisRackauckas ChrisRackauckas deleted the return_type branch December 12, 2021 13:09
@ChrisRackauckas
Copy link
Member Author

It looks like it was a bug that was fixed in v1.7 but should probably be backported to LTS.

@vpuri3
Copy link
Member

vpuri3 commented Dec 13, 2021

ok created an issue in julialang JuliaLang/LinearAlgebra.jl#895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants