-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
various CI improvements #501
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
==========================================
- Coverage 62.71% 56.61% -6.11%
==========================================
Files 29 29
Lines 2229 2222 -7
==========================================
- Hits 1398 1258 -140
- Misses 831 964 +133 ☔ View full report in Codecov by Sentry. |
@thazhemadam do you know what the issue is here? |
I'll need some help fixing this deprecation: https://github.com/SciML/LinearSolve.jl/actions/runs/9061500275/job/24893376530?pr=501#step:6:2073 |
@fredrikekre "LoadError: mpiexec() is deprecated, use the non-do-block form" do you know the fix here? |
diff --git a/test/hypretests.jl b/test/hypretests.jl
index c41079c1..da7e7e3a 100644
--- a/test/hypretests.jl
+++ b/test/hypretests.jl
@@ -168,7 +168,5 @@ test_interface(HYPREAlgorithm(HYPRE.PCG(comm)), Pl = HYPRE.BoomerAMG())
# Test MPI execution
mpitestfile = joinpath(@__DIR__, "hypretests_mpi.jl")
-mpiexec() do mpi
- r = run(ignorestatus(`$(mpi) -n 2 $(Base.julia_cmd()) $(mpitestfile)`))
- @test r.exitcode == 0
-end
+r = run(ignorestatus(`$(mpiexec()) -n 2 $(Base.julia_cmd()) $(mpitestfile)`))
+@test r.exitcode == 0 |
No description provided.