Skip to content

Fix check of factorisation #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

ZedThree
Copy link
Contributor

For appleaccelerate and mkl, the fact variable is a tuple, only the first element should be checked.

I think these cases must not be covered in your test suite, but I was getting the following error:

ERROR: MethodError: no method matching issuccess(::Tuple{LinearAlgebra.LU{Float64, Matrix{Float64}, Vector{Int64}}, Base.RefValue{Int64}})
The function `issuccess` exists, but no method is defined for this combination of argument types.

Closest candidates are:
  issuccess(::LinearAlgebra.BunchKaufman)
   @ LinearAlgebra ~/.julia/juliaup/julia-1.11.5+0.x64.linux.gnu/share/julia/stdlib/v1.11/LinearAlgebra/src/bunchkaufman.jl:321
  issuccess(::StaticArrays.LU)
   @ StaticArrays ~/.julia/packages/StaticArrays/LSPcF/src/lu.jl:71
  issuccess(::SparseArrays.CHOLMOD.Factor)
   @ SparseArrays ~/.julia/juliaup/julia-1.11.5+0.x64.linux.gnu/share/julia/stdlib/v1.11/SparseArrays/src/solvers/cholmod.jl:1958
  ...

Stacktrace:
  [1] solve!(cache::LinearSolve.LinearCache{…}, alg::LinearSolve.MKLLUFactorization; kwargs::@Kwargs{…})
    @ LinearSolve ~/.julia/packages/LinearSolve/cf5tu/src/mkl.jl:223

This was only for mkl, but I assume the appleaccelerate has the same issue

For `appleaccelerate` and `mkl`, the `fact` variable is a tuple, only
the first element should be checked
@ChrisRackauckas
Copy link
Member

Yes thank you. Yeah for hardware reasons these aren't covered well.

@ChrisRackauckas ChrisRackauckas merged commit f4aacff into SciML:main Jul 14, 2025
19 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants