Setup the codebase to use explicit imports #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+4
to
+5
| using LinearSolve: LinearSolve, is_cusparse, defaultalg, cudss_loaded, DefaultLinearSolver, | ||
| DefaultAlgorithmChoice, ALREADY_WARNED_CUDSS, LinearCache, needs_concrete_A, |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| using LinearSolve: LinearSolve, is_cusparse, defaultalg, cudss_loaded, DefaultLinearSolver, | |
| DefaultAlgorithmChoice, ALREADY_WARNED_CUDSS, LinearCache, needs_concrete_A, | |
| using LinearSolve: LinearSolve, is_cusparse, defaultalg, cudss_loaded, DefaultLinearSolver, | |
| DefaultAlgorithmChoice, ALREADY_WARNED_CUDSS, LinearCache, | |
| needs_concrete_A, |
Comment on lines
+3
to
+4
| using LinearSolve: LinearSolve, SciMLLinearSolveAlgorithm, init, solve!, LinearProblem, | ||
| LinearCache, AbstractKrylovSubspaceMethod, DefaultLinearSolver, |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| using LinearSolve: LinearSolve, SciMLLinearSolveAlgorithm, init, solve!, LinearProblem, | |
| LinearCache, AbstractKrylovSubspaceMethod, DefaultLinearSolver, | |
| using LinearSolve: LinearSolve, SciMLLinearSolveAlgorithm, init, solve!, LinearProblem, | |
| LinearCache, AbstractKrylovSubspaceMethod, DefaultLinearSolver, |
| @@ -1,7 +1,8 @@ | |||
| module LinearSolveRecursiveFactorizationExt | |||
|
|
|||
| using LinearSolve | |||
| using LinearSolve: LinearSolve, userecursivefactorization, LinearCache, @get_cacheval, RFLUFactorization | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| using LinearSolve: LinearSolve, userecursivefactorization, LinearCache, @get_cacheval, RFLUFactorization | |
| using LinearSolve: LinearSolve, userecursivefactorization, LinearCache, @get_cacheval, | |
| RFLUFactorization |
Comment on lines
+4
to
+6
| @get_cacheval, CHOLMODFactorization, GenericFactorization, GenericLUFactorization, | ||
| KLUFactorization, LUFactorization, NormalCholeskyFactorization, OperatorAssumptions, | ||
| QRFactorization, RFLUFactorization, UMFPACKFactorization, solve |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @get_cacheval, CHOLMODFactorization, GenericFactorization, GenericLUFactorization, | |
| KLUFactorization, LUFactorization, NormalCholeskyFactorization, OperatorAssumptions, | |
| QRFactorization, RFLUFactorization, UMFPACKFactorization, solve | |
| @get_cacheval, CHOLMODFactorization, GenericFactorization, | |
| GenericLUFactorization, | |
| KLUFactorization, LUFactorization, NormalCholeskyFactorization, | |
| OperatorAssumptions, | |
| QRFactorization, RFLUFactorization, UMFPACKFactorization, solve |
ChrisRackauckas
force-pushed
the
explicitimportscode
branch
from
ec4d975 to
2889418
Compare
| QRFactorization, RFLUFactorization, UMFPACKFactorization, solve | ||
| using ArrayInterface: ArrayInterface | ||
| using LinearAlgebra: LinearAlgebra, I, Hermitian, Symmetric, cholesky, ldiv!, lu, lu!, QR | ||
| using SparseArrays: SparseArrays, AbstractSparseArray, AbstractSparseMatrixCSC, SparseMatrixCSC, |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| using SparseArrays: SparseArrays, AbstractSparseArray, AbstractSparseMatrixCSC, SparseMatrixCSC, | |
| using SparseArrays: SparseArrays, AbstractSparseArray, AbstractSparseMatrixCSC, | |
| SparseMatrixCSC, |
Comment on lines
+10
to
+15
| using LinearAlgebra: LinearAlgebra, BlasInt, LU, Adjoint, BLAS, Bidiagonal, BunchKaufman, | ||
| ColumnNorm, Diagonal, Factorization, Hermitian, I, LAPACK, NoPivot, | ||
| RowMaximum, RowNonZero, SymTridiagonal, Symmetric, Transpose, | ||
| Tridiagonal, UniformScaling, axpby!, axpy!, bunchkaufman, bunchkaufman!, | ||
| cholesky, cholesky!, diagind, dot, inv, ldiv!, ldlt!, lu, lu!, mul!, norm, | ||
| qr, qr!, svd, svd! |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| using LinearAlgebra: LinearAlgebra, BlasInt, LU, Adjoint, BLAS, Bidiagonal, BunchKaufman, | |
| ColumnNorm, Diagonal, Factorization, Hermitian, I, LAPACK, NoPivot, | |
| RowMaximum, RowNonZero, SymTridiagonal, Symmetric, Transpose, | |
| Tridiagonal, UniformScaling, axpby!, axpy!, bunchkaufman, bunchkaufman!, | |
| cholesky, cholesky!, diagind, dot, inv, ldiv!, ldlt!, lu, lu!, mul!, norm, | |
| qr, qr!, svd, svd! | |
| using LinearAlgebra: LinearAlgebra, BlasInt, LU, Adjoint, BLAS, Bidiagonal, BunchKaufman, | |
| ColumnNorm, Diagonal, Factorization, Hermitian, I, LAPACK, NoPivot, | |
| RowMaximum, RowNonZero, SymTridiagonal, Symmetric, Transpose, | |
| Tridiagonal, UniformScaling, axpby!, axpy!, bunchkaufman, | |
| bunchkaufman!, | |
| cholesky, cholesky!, diagind, dot, inv, ldiv!, ldlt!, lu, lu!, mul!, | |
| norm, | |
| qr, qr!, svd, svd! |
Comment on lines
+19
to
+20
| using SciMLOperators: SciMLOperators, AbstractSciMLOperator, IdentityOperator, MatrixOperator, | ||
| has_ldiv!, issquare |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| using SciMLOperators: SciMLOperators, AbstractSciMLOperator, IdentityOperator, MatrixOperator, | |
| has_ldiv!, issquare | |
| using SciMLOperators: SciMLOperators, AbstractSciMLOperator, IdentityOperator, | |
| MatrixOperator, | |
| has_ldiv!, issquare |
Comment on lines
+27
to
+28
|
|
||
| @test check_no_implicit_imports(LinearSolve; skip = (Base, Core), |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test check_no_implicit_imports(LinearSolve; skip = (Base, Core), | |
| @test check_no_implicit_imports(LinearSolve; skip = (Base, Core), |
|
|
||
| @test check_no_implicit_imports(LinearSolve; skip = (Base, Core), | ||
| allow_unanalyzable = unanalyzable_mods) === nothing | ||
| @test check_no_stale_explicit_imports(LinearSolve; allow_unanalyzable = unanalyzable_mods) === nothing |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @test check_no_stale_explicit_imports(LinearSolve; allow_unanalyzable = unanalyzable_mods) === nothing | |
| @test check_no_stale_explicit_imports( | |
| LinearSolve; allow_unanalyzable = unanalyzable_mods) === nothing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.